Repository navigation
S0329-parser-first-use-path: execute both first examples and name any unexecuted runnable tag - #137
Merged
Merged
Conversation
… unexecuted runnable tag The quickstart's first CCD is committed byte for byte as test/__fixtures__/first-use/quickstart-ccd.xml, which pnpm phi-scan reads as a document, and the suite asserts the copy. Both first-use blocks (the quickstart's first and the first under the README Usage heading) are checked to be ones the two sweeps execute, run explicitly, and shown to go red on a changed claim; the quickstart's also on a changed input. Every fence tagged runnable in README.md or docs-content/ must be one the harness extracts, or the suite names it by file and line. Install commands are compared with package.json name. No document text changed, so no changeset.
…e, not a tracked .xml CI refused the committed test/__fixtures__/first-use/quickstart-ccd.xml: artifact-provenance asserts no XML document is ever tracked, because this repository keeps its C-CDA fixtures as XML embedded in test/__fixtures__/*.ts (which pnpm phi-scan reads). The quickstart CCD now lives there, as QUICKSTART_CCD in test/__fixtures__/first-use.ts, and the suite checks each first-use document literal against the embedded fixtures by value.
…s new TypeScript project does The snippet harness strips types without checking them, so pnpm test would stay green over a first-use example that does not compile. Both first examples now compile with the options tsc --init writes for a new project (strict, noUncheckedIndexedAccess, exactOptionalPropertyTypes, verbatimModuleSyntax, NodeNext), against src/index.ts, and the suite fails on any error the example itself carries. Both compile today; each carries a control that breaks its types and must be reported. The install-specifier reader also reads pnpm i, pnpm install, npm add and deno add npm:, stops a specifier at a full stop and skips a protocol specifier, so no printed form passes vacuously.
…first example turns the run red
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: cosyte/cosyte pipeline/active/S0329-parser-first-use-path/spec.md (child: children/ccda.md).
The README block was already executed at this pin (doc/code agreement (README) in test/docs-content.test.ts), so the ccda baseline is 2, recorded in the item notes. The README example builds its document with buildCcda, so it prints no document literal; the fixture-copy rule is applied to every document literal a first-use block prints, and that block prints none. No document text and no parser behaviour changed, so no changeset.