Repository navigation
Drop the .git suffix from the installation page's clone URL - #131
Merged
Merged
Conversation
docs.cosyte.com runs a repo-visibility gate on the build that publishes the site: every https://github.com/cosyte/<repo> link in the built HTML is checked against the manifest's repoPublic column. Its matcher allows a dot in the repository name, so `git clone https://github.com/cosyte/fhir.git` reads as a repository named fhir.git, which the manifest does not list, and the gate fails the publish run. Building the site with this docs-content staged and fhir enabled reproduced exactly that one failure (Pages: /fhir/installation); with the suffix dropped the same gate passes. git clone accepts the URL without the suffix, so the command a reader copies behaves the same. Nothing under src/ changes. Claude-Session: https://claude.ai/code/session_01U24bnHKNxQWMxmfN7ny7w9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The docs site's publish run (
dispatch-receiver.yml) runs a repo-visibility gate over the built HTML: everyhttps://github.com/cosyte/<repo>link is checked against its manifest. The matcher allows a dot in the repository name, so the installation page'sgit clone https://github.com/cosyte/fhir.gitreads as a repository namedfhir.gitthat the manifest does not list, and the gate fails the run.Found by building cosyte/docs locally with fhir enabled and this repo's current
docs-content/staged:check:repo-visibilityfailed with exactly that one problem (Pages: /fhir/installation), and passed once the suffix was dropped.What changes
docs-content/installation.md:git clone https://github.com/cosyte/fhir(no.git).git cloneaccepts both forms.src/.Checks
format:check, check:no-emdash, check:no-internal-refs, check:docs-set, and the docs-set, install-specifier and release-readiness test files pass locally.
Like #129, this reaches docs.cosyte.com only with the next fhir release.
https://claude.ai/code/session_01U24bnHKNxQWMxmfN7ny7w9