Repository navigation
Scope the seed-to-bytes promise to the installed parser versions - #67
Merged
Merged
Conversation
The 0.1.0 changeset and three documentation pages promised that a golden fixture pinned to a synth version keeps matching. Measured on this tree: with the vendored @cosyte/ccda 0.0.1 swapped for the 0.0.15 on npm, the same C-CDA seeds serialize to different bytes (the determinism digest fails for ccda seeds 1001, 4242, 60501 and 813377, and the three C-CDA golden fixtures and three C-CDA quirk fixtures stop matching), while the HL7 v2, FHIR, X12, NCPDP and ASTM pairs stay byte-identical. Each format's bytes come from that parser's own builder, so pinning synth alone does not pin them. The changeset and the limitations, overview and troubleshooting pages now tell a reader to pin the parsers they generate with alongside synth and the seed. Wording only: no code, test or gate changes. Claude-Session: https://claude.ai/code/session_01U24bnHKNxQWMxmfN7ny7w9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wording only: the 0.1.0 changeset and three documentation pages scope the seed-to-bytes promise to the installed parser versions. No code, test or gate changes.
Why
The changeset merged in #66 (and
docs-content/limitations.md,guides-overview.md,troubleshooting.mdbefore it) told a reader that pinning thesynthversion alongside the seed keeps a golden fixture matching. Measured onmainin a scratch worktree, with only the vendored@cosyte/ccda0.0.1 swapped for 0.0.15 from npm:determinism:digestFAILS against the committed baseline forccda/seed-1001,ccda/seed-4242,ccda/seed-60501andccda/seed-813377;test/ccda/round-trip.test.ts(3 golden fixtures) andtest/ccda/quirk.test.ts(3 quirk fixtures) stop regenerating byte-identically;Each format's bytes come from that parser's own builder, so a consumer who upgrades a parser can see different bytes with
synthunchanged. The text now says to pin the parsers too.Checks
check:no-internal-refs,check:no-emdash,phi-scan(all-mode),test/docs-content.test.ts(41 runnable blocks), and the shared release-notes renderer on the edited changeset (headline unchanged, no violations): all pass.https://claude.ai/code/session_01U24bnHKNxQWMxmfN7ny7w9