Docs and manifest update after splitting packages#102
Merged
Conversation
counsyl-opensource
approved these changes
Dec 5, 2018
counsyl-opensource
left a comment
counsyl-opensource
left a comment
Collaborator
There was a problem hiding this comment.
lgtm - small doc notes
anujkumar93
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jtratner
This PR handles the docs, left-over review comments and any other nuances that crept up after splitting the stor packages into 4 modules.
Background
This is a continuation of the story to split stor across 4 modules : stor, stor_dx, stor_swift, stor_s3. This is done to easy the dependencies that need to be installed to use a particular fact of stor, and to make it more modular. This PR is preceded by #101 for this story, and will be followed by a PR to generate requirements.txt dynamically to pin versions.
Changes
package_split.rst is updated to not have release_notes language, and hopefully makes things clearer
Manifests were added for each individual package, after checking with devpi. Have not removed the manifest at the top level, though maybe probably should.
Tested via:
The testing suite was run after the changes successfully, including the integration testing suite.
TODOS