fix(SchedulerWorker): log exceptions in child process instead of swallowing#178
Merged
fix(SchedulerWorker): log exceptions in child process instead of swallowing#178
Conversation
…lowing When a scheduled task throws an exception in a forked child process, the exception was silently swallowed. The parent only saw exit code 1 with no diagnostic information. Now the exception is logged via Worker::log() before exiting, providing: - task name - exception message - file and line where the exception occurred Fixes #157
s2x
commented
May 2, 2026
s2x
commented
May 2, 2026
Collaborator
Author
Review SummaryOverall the change looks good — it addresses issue #157 by logging exceptions in the child process catch block. Two inline suggestions above for improving the log message format. 🟡 Missing test coverageThe PR adds exception logging in the child process catch block, but there is no test verifying this behavior. While testing forked process exception handling is complex (similar to the existing |
- Add exception type ($e::class) to log message for quick identification - Add stack trace ($e->getTraceAsString()) for full diagnostic info - Add structural test verifying exception logging pattern Addresses PR review comments on #178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Worker::log()before exiting, providing diagnostic informationChanges
Before:
After:
Testing
--memory-limit=256M)