Skip to content

fix(SchedulerWorker): log exceptions in child process instead of swallowing #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s2x merged 2 commits into from
May 2, 2026
Merged

fix(SchedulerWorker): log exceptions in child process instead of swallowing #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b9f762
fix(SchedulerWorker): log exceptions in child process instead of swal…
May 2, 2026
0d6cf25
fix(SchedulerWorker): improve exception logging and add test
May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Worker/SchedulerWorker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,17 @@ private function runCallback(TriggerInterface $trigger, string $service, string
$childExitCode = 0;
try {
($this->handler)($service, $taskName);
} catch (\Throwable) {
} catch (\Throwable $e) {
Comment thread
s2x marked this conversation as resolved.
$this->worker->log(sprintf(
'%s Task "%s" failed: [%s] %s in %s:%d\nStack trace:\n%s',
$this->worker->name,
Comment thread
s2x marked this conversation as resolved.
$taskName,
$e::class,
$e->getMessage(),
$e->getFile(),
$e->getLine(),
$e->getTraceAsString(),
));
$childExitCode = 1;
} finally {
// Release lock, cleanup and exit
Expand Down
43 changes: 43 additions & 0 deletions tests/SchedulerWorkerSigchldTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,49 @@ public function testSchedulerWorkerUsesCorrectSignalPattern(): void
);
}

/**
* Structural test: verify SchedulerWorker logs exceptions in child process.
* This is a regression safety net for Issue #157 — if someone removes the
* exception logging or reverts to silently swallowing exceptions, this test
* catches it immediately.
*/
public function testSchedulerWorkerLogsExceptionsInChildProcess(): void
{
$sourceFile = dirname(__DIR__) . '/src/Worker/SchedulerWorker.php';
$this->assertFileExists($sourceFile);

$content = file_get_contents($sourceFile);
$this->assertNotFalse($content);

// Verify the catch block captures the exception variable
$this->assertStringContainsString(
'catch (\Throwable $e)',
$content,
'Catch block must capture exception variable for logging (Issue #157)',
);

// Verify the exception is logged via Worker::log()
$this->assertStringContainsString(
'$this->worker->log(sprintf(',
$content,
'Exception must be logged via Worker::log() in child process (Issue #157)',
);

// Verify the log message includes exception type
$this->assertStringContainsString(
'$e::class',
$content,
'Log message must include exception type for quick identification (Issue #157)',
);

// Verify the log message includes stack trace
$this->assertStringContainsString(
'$e->getTraceAsString()',
$content,
'Log message must include stack trace for full diagnostic information (Issue #157)',
);
}

/**
* Run a SIGCHLD test in an isolated PHP process to avoid PHPUnit
* state inheritance issues with pcntl_fork().
Expand Down