Repository navigation
Raise the coverage floors to what the suite now earns - #18
Merged
Merged
Conversation
Removing dead code and covering doctor took the project from 60.25% to 61.10% combined and the command modules from 36.83% to 38.44%, so the two floors move to 61 and 38. Both were checked to still fail one point higher. The comment carried the numbers from when the gate was introduced; it now carries the current ones, and says not to lower the floor to make a change pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the coverage floors to what the suite now earns
The project floor goes 60 to 61 and the command-module floor goes 36 to 38.
Changes
fail_under = 61inpyproject.toml.--fail-under=38on the command-module report inci.yml.fail_undernow carries current numbers instead of the ones from whenthe gate was introduced, and says not to lower the floor to make a change pass.
Constraints
These are the combined metric, not line coverage. With
branch = true,fail_undercompares the combined statement-and-branch percentage. On this commit that is 61.09% against
64.86% line and 44.91% branch, so both floor numbers read about four points below what a
line-coverage floor of the same name would mean.
The margin is deliberately thin. CI reports 61.09% and a local run reports 61.10%, so the
floor sits about 0.09 under with a 0.01 environment delta between the two. That is enough to
absorb the delta and not much else, which is the point of a ratchet: a change that adds a
meaningful amount of uncovered code should fail. Raise the floor in the same change as the
tests that earn it.
Both floors were checked to still fail.
--fail-under=62and--fail-under=39each exit2 against this data, so neither gate has gone slack.
Note
The 3.10 and 3.14 matrix entries now report the same number. They previously split 60.24 and
60.25; removing
list_reader_namesis the only change that could account for it.Verification
ruff check,ruff format --check,mypy, 350 tests, and both floors pass.🤖 Generated with Claude Code