Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ jobs:
# divergence is itself worth seeing.
- run: pytest -q -m "not real_card" --cov --cov-report=term-missing --cov-report=xml
# Second, tighter floor on the layer that actually needs to move: the command
# modules hold 1699 of the 2158 missed statements. coverage.py has no per-file
# modules hold 1658 of the 2111 missed statements. coverage.py has no per-file
# fail_under, so this is a separate report over the same data.
- run: coverage report --include='src/cryptnox_id_cli/cli/commands/*' --fail-under=36
- run: coverage report --include='src/cryptnox_id_cli/cli/commands/*' --fail-under=38
- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
if: ${{ !env.ACT && matrix.python-version == '3.14' }}
with:
Expand Down
11 changes: 6 additions & 5 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,9 @@ branch = true
show_missing = true
skip_covered = true
# NOTE: with branch = true, this gate compares the COMBINED statement-and-branch
# percentage that `coverage report` prints - not line coverage alone. At the time
# this gate was introduced the three numbers were 60.25% combined, 64.11% line,
# 43.62% branch, so reading it as a line-coverage floor overstates the suite by
# four points. Raise it in the same commit as the tests that earn the increase.
fail_under = 60
# percentage that `coverage report` prints - not line coverage alone. Today the
# three numbers are 61.09% combined, 64.86% line and 44.91% branch, so reading
# this as a line-coverage floor overstates the suite by nearly four points.
# Raise it in the same commit as the tests that earn the increase, and never
# lower it to make a change pass.
fail_under = 61
Loading