chore: fix golangci-lint config and regenerate mocks#29
Open
JayT106 wants to merge 4 commits intocrypto-org-chain:v0.38.xfrom
Open
chore: fix golangci-lint config and regenerate mocks#29JayT106 wants to merge 4 commits intocrypto-org-chain:v0.38.xfrom
JayT106 wants to merge 4 commits intocrypto-org-chain:v0.38.xfrom
Conversation
- Remove deprecated `golint` and `maligned` linter settings from `.golangci.yml` that cause golangci-lint v1.64+ to reject the config - Regenerate mocks with `make mockery metrics` to fix check-mocks-metrics CI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add golang.org/x/crypto, golang.org/x/net to depguard main allowlist - Add golang.org/x/crypto, google.golang.org/protobuf to depguard test allowlist - Fix gosimple S1009 in light/detector.go: remove redundant nil check before len() (len of nil slice is defined as zero) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add top-level prefixes for all external dependencies used in the
codebase to the depguard allowlists:
Main: golang.org/x/sync, gonum.org/v1/gonum, google.golang.org/grpc,
google.golang.org/protobuf
Test: golang.org/x/net, google.golang.org/grpc, google.golang.org/protobuf
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golintandmalignedlinter settings from.golangci.ymlmake mockery metricsProblem
Two CI checks have been failing on
v0.38.x:golangci-lint: golangci-lint v1.64+ rejects the config becausegolintandmalignedare no longer valid linter settings (additional properties 'golint', 'maligned' not allowed). Both linters were deprecated and removed in earlier golangci-lint versions.check-mocks-metrics: Generated mock files are out of date (12 files across abci, evidence, mempool, p2p, proxy, state packages).Changes
.golangci.yml: Removegolint.min-confidenceandmaligned.suggest-newsettings (lines 38-43)make mockery metricsNote
Two other CI failures (
govulncheck,tests (05)) are pre-existing and not addressed here:govulncheck: 21 known vulnerabilities in dependencies — requires dependency upgradestests (05): Flaky psql integration test — infrastructure issue🤖 Generated with Claude Code