chore: fix golangci-lint config and regenerate mocks

.changelog/unreleased/bug-fixes/29-fix-golangci-lint-config.md

@@ -0,0 +1,3 @@
+- `[ci]` Fix golangci-lint config: remove deprecated linter settings,
+  add missing depguard allowlist entries, and regenerate mocks.
+  ([#29](https://github.com/crypto-org-chain/cometbft/pull/29))

.golangci.yml

@@ -35,12 +35,8 @@ issues:
 linters-settings:
   dogsled:
     max-blank-identifiers: 3
-  golint:
-    min-confidence: 0
   goconst:
     ignore-tests: true
-  maligned:
-    suggest-new: true
   misspell:
     locale: US
   depguard:
@@ -77,6 +73,12 @@ linters-settings:
           - github.com/stretchr/testify/require
           - github.com/syndtr/goleveldb
           - github.com/decred/dcrd/dcrec/secp256k1/v4
+          - golang.org/x/crypto
+          - golang.org/x/net
+          - golang.org/x/sync
+          - gonum.org/v1/gonum
+          - google.golang.org/grpc
+          - google.golang.org/protobuf
       test:
         files:
           - "$test"
@@ -98,6 +100,10 @@ linters-settings:
           - github.com/spf13
           - github.com/stretchr/testify
           - github.com/decred/dcrd/dcrec/secp256k1/v4
+          - golang.org/x/crypto
+          - golang.org/x/net
+          - google.golang.org/grpc
+          - google.golang.org/protobuf
 
   revive:
     enable-all-rules: true

light/detector.go

@@ -26,7 +26,7 @@ import (
 // If there are no conflicting headers, the light client deems the verified target header
 // trusted and saves it to the trusted store.
 func (c *Client) detectDivergence(ctx context.Context, primaryTrace []*types.LightBlock, now time.Time) error {
-	if primaryTrace == nil || len(primaryTrace) < 2 {
+	if len(primaryTrace) < 2 {
 		return errors.New("nil or single block primary trace")
 	}
 	var (