Fix ProcessAbortDialog rendering outside its parent Dialog#421
Fix ProcessAbortDialog rendering outside its parent Dialog#421
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe changes restructure the emergency access dialog components. The ProcessAbortDialog component is repositioned to be rendered as a child within the Dialog element in EmergencyAccessDialog.vue. Simultaneously, ProcessAbortDialog.vue's DOM structure is refactored, removing an outer fixed container and introducing a flex-based wrapper for internal elements (TransitionChild and DialogPanel), while maintaining all styling and transition behavior. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
The
ProcessAbortDialogwas rendered outside of the parent<Dialog>component inEmergencyAccessDialog, which caused incorrect overlay stacking behaviour.This was especially noticeable on mobile, where the abort dialog rendered behind the parent overlay, making buttons unreachable. The dialog was moved inside the parent
<Dialog>to ensure correct rendering and overlay handling.