Skip to content

Fix ProcessAbortDialog rendering outside its parent Dialog#421

Open
mindmonk wants to merge 1 commit intodevelopfrom
feature/fix-emergency-access-abort-dialog
Open

Fix ProcessAbortDialog rendering outside its parent Dialog#421
mindmonk wants to merge 1 commit intodevelopfrom
feature/fix-emergency-access-abort-dialog

Conversation

@mindmonk
Copy link
Contributor

The ProcessAbortDialog was rendered outside of the parent <Dialog> component in EmergencyAccessDialog, which caused incorrect overlay stacking behaviour.

This was especially noticeable on mobile, where the abort dialog rendered behind the parent overlay, making buttons unreachable. The dialog was moved inside the parent <Dialog> to ensure correct rendering and overlay handling.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 14b57f05-5e6b-4d04-a25b-6824507fd97e

📥 Commits

Reviewing files that changed from the base of the PR and between 5614653 and 86dfd36.

📒 Files selected for processing (2)
  • frontend/src/components/emergencyaccess/EmergencyAccessDialog.vue
  • frontend/src/components/emergencyaccess/ProcessAbortDialog.vue

Walkthrough

The changes restructure the emergency access dialog components. The ProcessAbortDialog component is repositioned to be rendered as a child within the Dialog element in EmergencyAccessDialog.vue. Simultaneously, ProcessAbortDialog.vue's DOM structure is refactored, removing an outer fixed container and introducing a flex-based wrapper for internal elements (TransitionChild and DialogPanel), while maintaining all styling and transition behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: moving ProcessAbortDialog inside its parent Dialog component to fix rendering/stacking issues.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem (dialog rendering outside parent), its impact (mobile overlay stacking), and the solution (moving dialog inside).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/fix-emergency-access-abort-dialog
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

@mindmonk mindmonk requested a review from overheadhunter March 13, 2026 09:31
@overheadhunter overheadhunter added this to the 1.5.0 milestone Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants