Skip to content

Fix ProcessAbortDialog rendering outside its parent Dialog #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mindmonk wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix ProcessAbortDialog rendering outside its parent Dialog #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions frontend/src/components/emergencyaccess/EmergencyAccessDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,16 +295,15 @@
</DialogPanel>
</TransitionChild>
</div>
<ProcessAbortDialog
v-if="props.recoveryProcess"
ref="abortDialog"
:recovery-process-id="props.recoveryProcess.id"
@confirmed="handleRecoveryAborted"
@close="onAbortClosed"
/>
</Dialog>
</TransitionRoot>

<ProcessAbortDialog
v-if="props.recoveryProcess"
ref="abortDialog"
:recovery-process-id="props.recoveryProcess.id"
@confirmed="handleRecoveryAborted"
@close="onAbortClosed"
/>
</template>

<script setup lang="ts">
Expand Down
12 changes: 5 additions & 7 deletions frontend/src/components/emergencyaccess/ProcessAbortDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@
<DialogOverlay class="fixed inset-0 bg-gray-500/75 transition-opacity" />
</TransitionChild>

<div class="fixed inset-0 z-50 overflow-y-auto">
<div class="flex min-h-full items-end justify-center p-4 text-center sm:items-center sm:p-0">
<TransitionChild as="template" enter="ease-out duration-300" enter-from="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95" enter-to="opacity-100 translate-y-0 sm:scale-100" leave="ease-in duration-200" leave-from="opacity-100 translate-y-0 sm:scale-100" leave-to="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95">
<DialogPanel class="relative transform overflow-hidden rounded-lg bg-white text-left shadow-xl transition-all sm:my-8 sm:w-100 sm:max-w-lg">
<div class="flex min-h-full items-end justify-center p-4 text-center sm:items-center sm:p-0">
<TransitionChild as="template" enter="ease-out duration-300" enter-from="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95" enter-to="opacity-100 translate-y-0 sm:scale-100" leave="ease-in duration-200" leave-from="opacity-100 translate-y-0 sm:scale-100" leave-to="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95">
<DialogPanel class="relative transform overflow-hidden rounded-lg bg-white text-left shadow-xl transition-all sm:my-8 sm:w-100 sm:max-w-lg">
<div class="bg-white px-4 pt-5 pb-4 sm:p-6 sm:pb-4">
<div class="sm:flex sm:items-start">
<div class="mx-auto shrink-0 flex items-center justify-center h-12 w-12 rounded-full bg-red-100 sm:mx-0 sm:h-10 sm:w-10">
Expand Down Expand Up @@ -37,9 +36,8 @@
<p v-if="onAbortError != null" class="text-sm text-red-900 px-4 sm:px-6 text-right bg-red-50">
{{ t('common.unexpectedError', [onAbortError.message]) }}
</p>
</DialogPanel>
</TransitionChild>
</div>
</DialogPanel>
</TransitionChild>
</div>
</Dialog>
</TransitionRoot>
Expand Down
Loading