Skip to content

Fix sandbox empire ID collisions - #41

Merged
csheldrick merged 2 commits into
mainfrom
codex/fix-sandbox-empire-id-collision
Jul 15, 2026
Merged

csheldrick merged 2 commits into
mainfrom
codex/fix-sandbox-empire-id-collision

Conversation

@csheldrick

Copy link
Copy Markdown
Owner

Summary

  • make sandbox-created empire IDs probe state.empires before insertion
  • prevent a same-tick create → merge → create sequence from overwriting the first empire and corrupting ownership/dynasty references
  • add a public-API regression covering the complete lifecycle and record the durable constraint

Validation

  • npm run build
  • npm run lint
  • npm run test:unit (10 tests)
  • npm run report (deterministic replay passed)
  • npm test (health passed: 780 wars, 208 collapses)
  • noet verify check (4 declared checks green immediately after verification)

@csheldrick
csheldrick marked this pull request as ready for review July 15, 2026 18:56
@csheldrick
csheldrick merged commit bf07f7b into main Jul 15, 2026
1 check passed
@csheldrick
csheldrick deleted the codex/fix-sandbox-empire-id-collision branch July 15, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant