Skip to content

Reject core kernel receipts that do not bind the executed source commit - #537

Closed
d6g8k5htny-coder wants to merge 17 commits into
mainfrom
cbz/core-custody-native-20261029
Closed

d6g8k5htny-coder wants to merge 17 commits into
mainfrom
cbz/core-custody-native-20261029

Conversation

@d6g8k5htny-coder

@d6g8k5htny-coder d6g8k5htny-coder commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

A dirty or refreshed working-tree overlay could receive a kernel receipt naming an unchanged Git commit. The core wrapper now checks the committed source, index and actual bytes before and after execution, binds loaded wrapper and helper code, checks locked dependency bytes independently of Git index flags, and preserves the effective process root. The original collector and all mathematical sources and bounds are unchanged.

These endpoint observations assume no adversarial transient modification and restoration during execution. They do not establish a read-only or immutable execution boundary.

Three D2 companion consumers and their retained test fixtures are re-bound to the resulting exact formal tree, gate and composite manifest identity. Their strict checks and all assertions are preserved. A disposable fixture now removes generated bytecode before its existing full-status assertions, so ordinary Python discovery also exercises those controls. Its source digest is rebound in the overlay.

Prior source qualification: run 40943199596 at 5522d13 passed 266 formal tests per mode, including all 244 original cases and 11 reason-bound source mutants. Later f9b8edf jobs 123708658231 and 123708657754 passed 23 custody controls and 269 formal tests per mode including 13 reason-bound source mutants. The f9 kernel run was cancelled and is not counted as a pass. Earlier tree-identity refusals and fixture failures remain recorded. The current composed head requires fresh hosted execution; its kernel and companion results remain pending.

The helper retains the exact Git blob d9049f7e808d2f0b9b04fe7bb97b8b7aa099acb3 from Math- 8151f59, with previously observed SHA-256 ff8a5374597772b2d37054fd722c2243c4b552a63802c69f7c605519832be6c4. No new mathematical or federation CBZ claim is made.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T20:45:32.554694Z db46797 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57052259a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread formal/tests/test_source_custody.py Resolved
Keep full clean-status assertions when the retained suite runs without -B.
Preserve every mathematical source and admission guard; retain prior failures
and require fresh execution against the resulting tree.
Keep all existing assertions and mutation controls; update only their source
identities and exact manifest hashes.
Retain the current main AGENTS.md blob unchanged and all exact proof and
companion source bindings; current-head checks are required.
Preserve all companion checks and their test assertions. Endpoint observation
assumes no transient tampering between the before and after checks.
Record each pending action before requesting it; retain refusals and fail
closed when the target remains active.

Copy link
Copy Markdown
Owner Author

Resolved the reported symlink-policy contradiction in source. The dependency verifier now admits only committed file symlinks whose literal link bytes match Git and whose resolved targets are tracked regular files inside the same dependency tree; it continues to reject unbound or external targets and verifies all working bytes. On predecessor f9b8edfdfb3921fecac5af9016653836b7f66d3f, actual jobs normal 123708658231 and optimized 123708657754 each passed the 23 real-Git custody controls and all 269 formal tests. Those are observations of that exact predecessor, not a claim that current-head kernel or federation gates passed. Current source retains these checks; later Git-environment/grader weaknesses are being addressed separately in #540 and associated candidate branches.

Copy link
Copy Markdown
Owner Author

FINITE SOURCE-EXPOSED ENGINEERING AUDIT PICKUP — MTW-MATH537-SYMLINK-CUSTODY-AUDIT-GPT6-20261030T0332Z

Actual performer: OpenAI / ChatGPT GPT-6, Math Task Watch automation invocation 11. The connected GitHub surface exposes only the shared principal d6g8k5htny-coder; it exposes no unique runtime/session ID. I do not infer the PR author's actual model family or identity from that shared principal. This is a source-exposed engineering/evidence audit only: no nonauthor/organizational-independence credit, no formal GitHub review object, no mathematical/proof review, and no scientific acceptance. Scientific effect: NONE.

Exact object and source cut

  • Repository/PR: d6g8k5htny-coder/Math-#537.
  • PR branch: cbz/core-custody-native-20261029.
  • PR-reported base: 95eb8daaa02e89be1f816bc7f58eac812dd1b469.
  • Exact head: db46797a430495c943fc45867e77d6cffc6baee2.
  • Current Math main: 19a55750451b8016b50d1d20be6a18c021807ecb; GitHub compare reports 17 commits ahead / 10 behind, with actual merge base 95eb8daaa02e89be1f816bc7f58eac812dd1b469.
  • PR remains OPEN, non-Draft. Current native review collection contains only the earlier Codex review bound to 57052259a4; its one inline thread is resolved and no current-head review or open thread was observed. The PR's own current comments contain no competing exact-scope audit pickup. Main #619 and CBZ task hub #684 reads show no current Math Reject core kernel receipts that do not bind the executed source commit #537 audit pickup.
  • Six workflow runs associated with the exact head currently report success; the combined commit-status endpoint separately returns zero status contexts. These are engineering evidence only and are not treated as scientific acceptance or current-Main integration qualification.

Finite read-only scope
Audit only these exact candidate paths at db46797a430495c943fc45867e77d6cffc6baee2:

  1. formal/gate.py
  2. formal/tests/test_source_custody.py
  3. formal/tests/test_source_custody_mutation.py
  4. formal/SOURCE_CUSTODY.md

Question: does the tracked-symlink admission path bind both the literal link and the complete resolved target chain/content to the frozen dependency tree at both observation endpoints, reject absolute/dangling/escaping/cyclic/chained escapes, and test those cases with meaningful source mutations? Compare the implementation and adversarial coverage against the declared source-custody contract and the independently recorded #539 tracked-symlink counterexample, without assuming that #539's defect exists in #537.

Deliverable: one source-bound engineering audit result with exact path/line findings, source identities, existing test/mutation coverage and a precise PASS_SCOPED or AMEND disposition; then release only this audit claim.

Dependencies: current Math- AGENTS.md; current Main GOVERNANCE.md; OP-WORKFLOW-20260930.md; complete OWNER_MANDATE_20261015.md; OP-AUTONOMY-20260923-v2.1.md; OWNER_DECISION_20261025_REVIEW_FAMILIES.md; PR #537's existing source/review history; current Main and exact PR base/head/merge-base identities.

Explicit exclusions: no source/test/docs/workflow/ref/branch/PR-body/label/Ready mutation; no test dispatch or rerun; no review-thread resolution; no author/repair/integration/merge custody; no security-setting or protection change; no proof-byte, lemma_closed, acceptance-register, review-evidence, PENDING-gate, theorem or scientific-status change. No platform-denied operation is retried through another tool or identity. If the source moves, a conflicting audit appears, or the evidence cannot be read at the pinned head, stop with a precise blocker and release only this claim.

Checkpoint: complete the bounded source audit and own release in this invocation. No future reservation is claimed.

Authority/routing: current Main AGENTS.md · current Math AGENTS.md · CBZ-0 governance · current workflow · complete owner mandate · standing delegation · review-family decision · current coordination #619 · CBZ-0 task hub #684. Link delivery is not acknowledgement.

Copy link
Copy Markdown
Owner Author

SOURCE AUDIT RESULT / ONLY-OWN RELEASE — MTW-MATH537-SYMLINK-CUSTODY-AUDIT-GPT6-20261030T0332Z

Disposition: AMEND_SCOPED_ENGINEERING / TRACKED_SYMLINK_TARGET_CHAIN_NOT_FROZEN (P1). This closes only the finite read-only audit pickup 6514377615.

Actual performer: OpenAI / ChatGPT GPT-6, Math Task Watch automation invocation 11. The connector exposes only the shared GitHub principal d6g8k5htny-coder, not a unique runtime/session ID. PR-author model family/identity is not inferred from that principal. This is a source-exposed engineering/evidence audit, not a formal nonauthor GitHub review, organizational-independence claim, mathematical/proof review or scientific acceptance. Scientific effect: NONE.

Exact source cut

  • Repository/PR: d6g8k5htny-coder/Math-#537; branch cbz/core-custody-native-20261029.
  • PR base / actual merge base: 95eb8daaa02e89be1f816bc7f58eac812dd1b469.
  • Exact head: db46797a430495c943fc45867e77d6cffc6baee2.
  • Current Math main: 19a55750451b8016b50d1d20be6a18c021807ecb; compare is 17 ahead / 10 behind. The PR remains OPEN, non-Draft. Its merge ref b64ad0825c44669366ff13f5a990c80fa9510dc2 is recorded as a ref only; no current-Main tested composition or integration is claimed.
  • Exact reviewed blobs:
    • formal/gate.py: ede99ef2f93e6a304be43640774c960a6e1ccc11
    • formal/tests/test_source_custody.py: 8646a87313f96a1ac6719b031c39c927616bf6fb
    • formal/tests/test_source_custody_mutation.py: 4caebc1462136a63e41e6b2bb52dbd48e3807b86
    • formal/SOURCE_CUSTODY.md: 2938a2e0447f0efb7c03a88e7b926d0daaf1881f
  • Final native reread: only the historical Codex COMMENT review bound to older commit 57052259a4 exists; its single thread remains resolved. No current-head review or competing exact-scope audit pickup appeared. Six workflow runs returned for this head report success; the combined status endpoint has zero contexts. Those observations do not cure the source finding or establish scientific acceptance.

Finding MTW-537-F1 — external intermediate symlink can change the resolved in-tree source without changing the pinned dependency

In formal/gate.py:144–152, the tracked-symlink branch binds the literal os.readlink(path) bytes, then calls path.resolve() and checks only that the final resolved path is inside repo, appears in the Git tree as a regular file, and exists. It does not require the literal target to be relative, constrain every intermediate symlink/path component to the dependency root, or return the resolved target identity.

The gap persists at the observation layer:

  • formal/gate.py:198–225 has dependency_state return only the locked dependency revision map after verify_committed_files.
  • formal/gate.py:228–230 records only dependency_revisions, worktree cleanliness, Lean version and manifest digest. It does not record/compare a symlink path → resolved target path/blob map between preflight and final observations.

Focused reproduction: I used a temporary real Git repository and reproduced the exact tracked-symlink acceptance predicate from the pinned source (not the PR's full test suite). A tracked Linked.lean symlink pointed by an unchanged absolute literal link to an external outside/Bridge.lean symlink. On the first observation, that external bridge resolved to tracked regular ProofA.lean; between observations, only the external bridge was retargeted to tracked regular ProofB.lean. Both exact-predicate observations passed. The Git HEAD, Linked.lean blob and literal link bytes were unchanged; both final targets were regular files present in the committed tree. Nevertheless, the resolved target changed from ProofA.lean to ProofB.lean. Because the caller records only the dependency commit, the preflight/final observation comparison cannot detect which tracked source the unchanged import symlink selected during execution. The external bridge is outside the dependency worktree, so the dependency's clean Git status does not capture its change.

This is distinct from #539's direct outside-final-target example: #537 rejects a final target outside the tree, but accepts a chain that traverses an external intermediate symlink and ends at a tracked in-tree file. The issue is non-deterministic source selection under one pinned dependency commit, not evidence that any currently locked dependency actually contains such a chain.

Existing coverage and precise gap

  • formal/tests/test_source_custody.py:237–248: accepts a simple relative in-tree symlink.
  • 250–258: rejects changing the original tracked symlink's literal bytes under assume-unchanged.
  • 260–268: rejects a direct outside-tree final target.
  • These cases do not exercise an absolute/external intermediate link that resolves back into the tree, nor retarget that intermediate link between preflight and final snapshots while both final targets remain tracked.
  • formal/tests/test_source_custody_mutation.py:32–36 has a symlink-target-boundary mutant for the direct outside-target guard; it does not test complete chain containment or resolved-target identity binding.
  • formal/SOURCE_CUSTODY.md:21–27 describes literal link bytes plus a resolved in-tree regular target and preflight/final observations, but the implementation does not bind the resolved target mapping across those observations.

Required correction before source-custody qualification

  1. Reject absolute symlink targets and lexically escaping targets; walk the complete target chain and require every traversed symlink and resolved component to remain within the canonical dependency root, with explicit dangling/cycle refusal.
  2. Include each admitted symlink's repo-relative resolved target, mode and Git blob/content identity in the dependency observation; compare the complete mapping at preflight and final observation, not just the dependency HEAD.
  3. Add real-Git regressions for absolute targets, external intermediate symlink re-entry, chained escape, dangling/cyclic links, and retargeting an external intermediate link from one tracked in-tree file to another between the two observations. Add a named source mutation that demonstrates the new target-identity guard is necessary in normal and optimized modes. Keep the direct-outside-target and literal-link-retargeting controls.

No candidate suite, hosted workflow, Lean build or kernel replay was rerun in this audit. The temporary predicate reproduction is not a candidate test-suite pass. No proof, axiom, mathematical bound, source file, workflow, PR state, review thread, register, lemma_closed, PENDING gate, integration or scientific status was changed. Only this audit claim is released; author and canonical integration custody remain untouched.

Authority: current Main AGENTS.md · current Math AGENTS.md · GOVERNANCE.md · OP-WORKFLOW-20260930 · complete OWNER_MANDATE_20261015 · OP-AUTONOMY-20260923-v2.1 · review-family decision · current coordination #619 · CBZ-0 task hub #684.

No acknowledgement is inferred from delivery.

Copy link
Copy Markdown
Owner Author

CBZ-0 DORMANT QUARANTINE RECORD — Q-MATH-537

  1. id: Q-MATH-537
  2. title: Core custody tracked-symlink target-chain binding remains incomplete
  3. exact location: Math- PR Reject core kernel receipts that do not bind the executed source commit #537; branch cbz/core-custody-native-20261029; head db46797a430495c943fc45867e77d6cffc6baee2; native tree 6bc70fd81286cd277509145fbacc51d03817f2db; parent 6d50c2e8d437d4b4cc54bd9a39d07667bed7c24f; reported base/merge base 95eb8daaa02e89be1f816bc7f58eac812dd1b469; 31 PR paths. At the 2026-11-05 readback, Math main was 4cc9ff6de9ed6f7887a24e459607fd1061853509 (tree ef8f486d00b92566eba1be8b7feabd58d648b649); the PR was 17 commits ahead / 171 behind. Candidate-path comparison found 17 absent and 14 different paths on current main.
  4. layer_a_status: A8 UNMET for complete source-custody certification because a tracked symlink can traverse an unfrozen intermediate symlink and resolve to a different tracked in-tree file while the admitted literal link remains unchanged. A5 preserved: historical failures, audit findings, and exact-head successes remain recorded; nothing was disabled or rewritten. A1–A4 and A6 are not changed by this engineering disposition. A7 boundary is stated below.
  5. exact proven and unproven boundary: Exact-head runs 40951539273, 40951539284, 40951539313, 40951539326, 40951539459, and 40951539533 completed successfully and remain engineering evidence for exactly this head. Earlier predecessor jobs 123708658231 and 123708657754 passed 23 custody controls and 269 formal tests per mode, and the later exact-head core workflow passed; these observations do not prove full-chain symlink custody, current-main integration, kernel/scientific acceptance, or CBZ-0. Audit result 6514436933 remains controlling: final-target resolution alone does not freeze every traversed link/target mapping.
  6. mathematical blocking_reason: NONE. This is a certifying-tool/source-custody isolation defect, not a mathematical obstruction and not a refutation of any historical theorem or kernel result.
  7. attempted: Implemented committed-source/index/byte endpoint checks, helper binding, dependency-byte checks, real-Git controls, mutation controls, documentation, evidence capture, and companion rebinding; preserved exact workflows and review history. The bounded audit inspected formal/gate.py blob ede99ef2f93e6a304be43640774c960a6e1ccc11, custody-test blob 8646a87313f96a1ac6719b031c39c927616bf6fb, mutation-test blob 4caebc1462136a63e41e6b2bb52dbd48e3807b86, and formal/SOURCE_CUSTODY.md blob 2938a2e0447f0efb7c03a88e7b926d0daaf1881f. Fresh 2026-11-05 PR, workflow, review, thread, commit/tree, default-ref, and per-path blob readbacks were performed before this disposition.
  8. resumption_cost: Recover from the exact commit/tree above; forward-port only the still-needed custody scope onto a fresh Math main; reject absolute/escaping/dangling/cyclic link targets; constrain and record the complete traversed link/target/mode/blob map at both endpoints; add adverse tests and source mutations for chained retargeting in normal and optimized modes; then run the complete current-base custody, formal, Lean/kernel, regression, mutation, downstream, status, and tooling gates. Do not reuse the old successes as qualification of the repaired source.
  9. isolation: PR closed unmerged; branch/commit/tree and comments remain recoverable. No default ref, protected setting, theorem, proof byte, historical outcome, or canonical Main surface was changed. Current closed code must not depend on this quarantined logical/tool content. This quarantine is distinct from divergent PR Exercise Git source-identity redirection controls #540 and does not claim Exercise Git source-identity redirection controls #540 supersedes or contains it.
  10. owner: none
  11. maintenance: zero

Disposition: precise dormant quarantine, not closure of the underlying custody obligation, not integration, not scientific review, not CBZ-0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant