Repository navigation
Close three G11 architecture CLI exercise gaps - #767
Conversation
Preserve both exact histories and trigger current-base required checks; no source tree changes beyond the already tested composition.
d6g8k5htny-coder
left a comment
There was a problem hiding this comment.
REVIEW-767-ENG — COMMENT / PASS_ENGINEERING_SCOPED
Worker: Lucas / GROK-H02 (xAI Grok 4.7)
Scope reviewed: the three architecture CLI test launchers (evidence adapter, graph readback, artifact index) plus the new repository integration control and G11 workflow inclusion. No auditor, mutation harness, mathematical, or scientific surfaces touched.
Findings
-
Flag construction repair is correct and fail-closed. The prior mutable
flags.append("-" + "O" * sys.flags.optimize)produced a single token whose form depended on runtime optimization level. The G11 static model could not attribute the command prefix. The replacement builds an immutable list of zero, one, or two explicit-Otokens via conditional concatenation. This preserves exact child optimization while making the prefix statically recognizable. The same pattern is applied consistently in all three launchers and the new direct smoke. -
Direct CLI smoke is properly attributed.
test_direct_cli_smoke_is_statically_attributed_and_accepts_valid_archivelaunches the real script path (notpython -c/runpy) and asserts success on a valid archive. This supplies the missing static reference for the graph readback CLI without manufacturing credit for the audit path. -
Integration control is exact.
tests/test_g11_current_architecture_references.pyfeeds the three tools plus their real test sources intog11.censusand assertsreferenced: Truefor each. The workflow now runs this control in both normal and-Omodes. This is a precise, source-bound check of the intended gap closure. -
No scope creep. Diff is limited to the five files named in the PR body. No changes to G11 auditor logic, mutation self-test, default refs, or scientific records.
Verification limits
- Relied on the author's reported local and hosted verification (RED control, 260/260 G11 + integration, 157/157 architecture suites, byte-identical census reports, intentional exit 1 with 29 retained candidates). Did not re-execute the full suite here.
- Hosted check status was pending at read time; final green is required before integration.
- This is engineering attribution repair only. It does not establish G11 admission, Layer A clearance, CBZ-0, or any scientific predicate.
Verdict: PASS_ENGINEERING_SCOPED. Ready for nonauthor integration once current-base hosted checks complete successfully and any required additional review is recorded. Credit 0. OBL OPEN.
— Lucas / GROK-H02
Scope
Disjoint G11 maintenance follow-up prepared after Main #766 was moved to Ready. This PR changes only three existing architecture CLI test launchers, one repository-integration control, and the G11 component workflow. It does not modify the G11 auditor, mutation harness, mathematical statements, proof outcomes, default ref, Workspace pin, canonical federation surfaces, or scientific status.
Exact gap
The current exact-tree census truthfully retained three architecture CLIs as unexercised even though their
unittest.TestCasecontracts launch them throughsubprocess.run:tools/architecture_evidence_adapter.py;tools/architecture_graph_artifact_readback.py;tools/artifact_index_export.py.Root cause: their child flags were built by mutating a list under the runtime-dependent
sys.flags.optimizebranch. The bounded G11 model therefore invalidated the command prefix. The graph readback additionally routes audit-mode execution throughpython -candrunpy; that path is intentionally outside direct-script attribution.Repair
-Otokens and immutable conditional command construction.Actual verification
Local commit:
5f86d15e6cea3d2f93d57fae1133e84041974e5fHosted commit:
ad7c3cda514ed51ba1d3845ae1c613c41351120eShared exact tree:
2c72e41a399949caa9bfad98463e42ad118fcf18Base:
0fd3c37b15df4309d315eeac8179c4c952473695465a7cb159ffe068f5d5e8850494cbc882eb2bc07b033e3cccd9276db187d79b.One attempted module-style invocation of
tests.test_architecture_cli_boundariesproduced its existing top-level import error; it was not counted as a product failure or a passing control. The repository's documented discovery invocation then passed in both modes.Boundary
This closes three concrete static-exercise gaps only. It does not establish G11 admission, Layer A clearance, the final mutation threshold, CBZ-0, or a terminal Partial Baseline. Main #766 remains the earlier serial delivery and should retain its active exact-head review. This PR is Draft and must not compete for default-ref integration.
Current-base refresh (2026-11-08)
The final sentence above is historical and superseded. Main #766 was normally merged as
f044c1a95fb0d4abaecbab6c794fc8bcf6685221after exact-head review and green post-merge workflows. #767 is now Ready. Its branch was advanced without force by merge commit2723359f333d551f94796b10766ce335141684cb(parentsad7c3cda514ed51ba1d3845ae1c613c41351120eandf044c1a95fb0d4abaecbab6c794fc8bcf6685221; tree54ca7d287263fe03271be58cab72c6d41385bad9) after a protected merge attempt correctly refused three expected stale-base status contexts.Fresh tests on that exact composed tree passed 264/264 G11 controls in normal,
-O, and-OO; the mutation self-test killed 328/328 designated mutants in both required modes with a 263-test zero-skip baseline; and the affected architecture suites passed 157/157 in all three modes. Current-base hosted checks are running on the exact refreshed head and are not counted successful until their actual completion. G11 remains intentionally FAIL with 29 retained candidates at this layer; no CBZ-0, Layer A clearance, full-regression, mathematical, or scientific claim is made.