Repository navigation
fix: keep recording active when windows close or minimize - #39
Merged
Merged
Conversation
(cherry picked from commit fd3cc3d)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
daniellee-ux
deleted the
codex/background-recording-window-lifecycle
branch
September 26, 2026 06:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the recording window previously stopped and finalized capture, and hidden recordings had no activity assertion to prevent App Nap. Move capture, transcription, notes, timing, and finalization into an app-owned
RecordingSession, so closing or minimizing a window keeps the session running and reopening reconnects to it.Validation: macOS build passed. All 58 selected regression tests passed, including 8 new recording-session tests covering minimize/close/reopen, explicit pause, startup cancellation, capture failure, duplicate stop, and saving without a view. The full suite encountered timeouts in the existing ChatGPT connection tests. Long-duration recording with physical audio devices still needs manual verification; the Mac was locked during the attempted UI check.
Review context: these changes already landed directly on
masterin fd3cc3d. This retrospective PR replays that exact change from its preceding commit to provide the complete review diff. The branch's file tree is identical to that landed commit and tomasterat PR creation.