Make the BC3 shaders compatible with GLSL ES version 310 - #12
Open
nanley wants to merge 8 commits into
Open
Conversation
Owner
|
nanley
force-pushed
the
es31-bc3-shaders
branch
from
October 4, 2022 22:32
ffab5ee to
79fb671
Compare
Author
|
Updated WRT to Vulkan compatibility, we shouldn't need to change the version directive right? AFAICT, One downside I've noticed with the PR's usage of rg32 and rgba16 (c2f0e02) is that it'd require a Vulkan app to set |
Increases compatibility with GLSL ES version 310.
nanley
force-pushed
the
es31-bc3-shaders
branch
from
October 26, 2022 04:03
79fb671 to
834c79d
Compare
This is a better fit for indexing and for using as a boolean. While we're here, avoid implicit data type conversions with the elements in the uniform. This increases compatibility with GLSL ES version 310.
Increases compatibility with GLSL ES version 310.
Increases compatibility with GLSL ES version 310.
Increases compatibility with GLSL ES version 310.
To be used in the following commit.
Increases compatibility with GLSL ES version 310. The ARB_shader_image_load_store extension says, For textures allocated by the GL, an image unit format is compatible with a texture internal format if they match by size. The textures were allocated by the GL implementation, so this format substitution is safe to do.
The shaders are compatible with GLSL ES version 310. Require the GL_ARB_ES3_1_compatibility extension and change the version directives accordingly so that we get validation from the GL implementation.
nanley
force-pushed
the
es31-bc3-shaders
branch
from
November 10, 2022 19:29
834c79d to
38a46c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on a collection of changes I had to make when I tried to compile these shaders in gles31 apps. Please let me know what you think.