Cache WorkerState host property#9044
Merged
Merged
Conversation
This was referenced Apr 16, 2025
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
distributed/scheduler.py:569
- Caching the host property at initialization may lead to inconsistencies if self.address changes later. Please confirm that the worker's address remains constant after initialization.
self.host = get_address_host(self.address)
distributed/scheduler.py:587
- Removing the dynamic host property in favor of a cached value requires ensuring that no dependent code relies on its dynamic computation. Verify that this change will not affect behaviors expecting an updated host value.
@property
def host(self) -> str:
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 21m 52s ⏱️ + 5m 42s For more details on these failures, see this check. Results for commit 53fad01. ± Comparison against base commit 16aa189. ♻️ This comment has been updated with latest results. |
jrbourbeau
approved these changes
Apr 16, 2025
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
LGTM -- test failures seem unrelated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9043