Skip to content

Cache WorkerState host property #9044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjetter merged 3 commits into from
Apr 16, 2025
Merged

Cache WorkerState host property #9044

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d27022f
Cache WorkerState.host
fjetter Apr 16, 2025
d084e58
as attribute
fjetter Apr 16, 2025
53fad01
final hints
fjetter Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions distributed/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,16 @@
)
from contextlib import suppress
from functools import partial
from typing import TYPE_CHECKING, Any, ClassVar, Literal, NamedTuple, cast, overload
from typing import (
TYPE_CHECKING,
Any,
ClassVar,
Final,
Literal,
NamedTuple,
cast,
overload,
)

import psutil
import tornado.web
Expand Down Expand Up @@ -413,7 +422,7 @@ class WorkerState:

#: This worker's unique key. This can be its connected address
#: (such as ``"tcp://127.0.0.1:8891"``) or an alias (such as ``"alice"``).
address: str
address: Final[str]

pid: int
name: Hashable
Expand Down Expand Up @@ -513,6 +522,9 @@ class WorkerState:
#: on the worker.
needs_what: dict[TaskState, int]

#: The hostname / IP address identifying the machine this worker is on.
host: Final[str]

__slots__ = tuple(__annotations__)

def __init__(
Expand Down Expand Up @@ -564,6 +576,7 @@ def __init__(
self.needs_what = {}
self._network_occ = 0
self._occupancy_cache = None
self.host = get_address_host(self.address)

def __hash__(self) -> int:
return self._hash
Expand All @@ -584,10 +597,6 @@ def has_what(self) -> Set[TaskState]:
"""
return self._has_what.keys()

@property
def host(self) -> str:
return get_address_host(self.address)

@property
def memory(self) -> MemoryState:
"""Polished memory metrics for the worker.
Expand Down
Loading