Repository navigation
Reapply #261: deterministic order for tied Hash Stats adopters (#256) - #293
Merged
Merged
Conversation
…ts-stable-sort" Re-applies #261 (deterministic order for tied Hash Stats adopters, #256), which was reverted by #275 after an automated keystroke answered a review agent's question; see the correction on #261. The change is byte-for-byte the reviewed #261 diff. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #256
Re-applies #261 ("deterministic order for tied Hash Stats adopters"), reverted by #275.
What this is
git revert 079cc7ee, which reverts the revert commit from Revert unauthorized merge of #261 (ready/merge performed by a review agent outside its authorization) #275.5e889a88^1..5e889a88). Only hunk positions and context differ, becausecmd/server/store.gochanged on master since then.cmd/server/store.go, where tied adopters get a stable secondary sort onpubkey, and the_256tests.GetSubpathDetail, the same bug class).Tests
go build ./...incmd/server.go test -run '_256$'(local).🤖 Generated with Claude Code