Skip to content

Revert goproxy 1.8.4 bump - #138

Merged
v-kbukum1 merged 1 commit into
mainfrom
kbukum/revert-goproxy-bump
Jun 9, 2026
Merged

v-kbukum1 merged 1 commit into
mainfrom
kbukum/revert-goproxy-bump

Conversation

@v-kbukum1

Copy link
Copy Markdown
Contributor

Context

Reverts #131, which bumped github.com/elazarl/goproxy to 1.8.4.

After the deployed proxy tag containing that bump, Cargo jobs started failing while downloading sparse-index entries from index.crates.io with:

[8] Weird server reply (Invalid status line)

We reproduced the failing Cargo job through the Dependabot proxy path, then reran the same job using the pre-#131 proxy tag and it completed successfully. That points to the goproxy bump as the likely regression source rather than the Cargo image.

Validation

go test ./...

The same Cargo job was also replayed successfully with the pre-#131 proxy image.

…c20506380 to 1.8.4 (#131)"

This reverts commit 91eaa33.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 9, 2026 00:49
@v-kbukum1
v-kbukum1 requested a review from a team as a code owner June 9, 2026 00:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the github.com/elazarl/goproxy upgrade to v1.8.4 by pinning the dependency back to the prior pseudo-version and updating the vendored goproxy sources accordingly, aiming to resolve Cargo sparse-index failures observed after the bump.

Changes:

  • Downgrade github.com/elazarl/goproxy from v1.8.4 back to v0.0.0-20240726154733-8b0c20506380 in go.mod/go.sum.
  • Refresh vendored module metadata (vendor/modules.txt) and vendored goproxy code to match the reverted version.
  • Remove vendored goproxy internal packages/files that were introduced by the bumped version.
Show a summary per file
File Description
go.mod Re-pins goproxy dependency back to the pre-bump pseudo-version.
go.sum Removes v1.8.4 checksums and restores checksums for the reverted goproxy version (and related entries).
vendor/modules.txt Updates vendored module list to reflect reverted goproxy version and package list.
vendor/github.com/elazarl/goproxy/.golangci.yml Removes vendored linter config from the bumped goproxy version.
vendor/github.com/elazarl/goproxy/README.md Restores the vendored README content consistent with the reverted version.
vendor/github.com/elazarl/goproxy/actions.go Restores handler interface docs/formatting consistent with reverted version.
vendor/github.com/elazarl/goproxy/certs.go Restores CA/init and TLS defaults consistent with reverted version.
vendor/github.com/elazarl/goproxy/chunked.go Adds vendored chunked writer used by the reverted HTTPS MITM response path.
vendor/github.com/elazarl/goproxy/counterecryptor.go Moves signer RNG helper into the main goproxy package and adjusts key support.
vendor/github.com/elazarl/goproxy/ctx.go Restores ProxyCtx and logging/charset behavior consistent with reverted version.
vendor/github.com/elazarl/goproxy/dispatcher.go Restores request/response condition helpers consistent with reverted version.
vendor/github.com/elazarl/goproxy/doc.go Restores vendored package documentation formatting/content.
vendor/github.com/elazarl/goproxy/h2.go Restores HTTP/2 transport/proxying implementation consistent with reverted version.
vendor/github.com/elazarl/goproxy/http.go Removes the v1.8.4 HTTP handling implementation (moved/changed in reverted version).
vendor/github.com/elazarl/goproxy/https.go Restores CONNECT/MITM and upstream proxy-dial behavior consistent with reverted version.
vendor/github.com/elazarl/goproxy/logger.go Restores Logger interface typing used by the reverted version.
vendor/github.com/elazarl/goproxy/proxy.go Restores core proxy implementation consistent with reverted version.
vendor/github.com/elazarl/goproxy/responses.go Restores response helper implementation consistent with reverted version.
vendor/github.com/elazarl/goproxy/signer.go Adds/relocates certificate signing implementation used by reverted MITM flow.
vendor/github.com/elazarl/goproxy/websocket.go Restores WebSocket proxying/handshake implementation consistent with reverted version.
vendor/github.com/elazarl/goproxy/internal/http1parser/header.go Removes bumped-version HTTP/1 header parser internals.
vendor/github.com/elazarl/goproxy/internal/http1parser/request.go Removes bumped-version HTTP/1 request reader internals.
vendor/github.com/elazarl/goproxy/internal/signer/signer.go Removes bumped-version signer internals (replaced by top-level signer logic).

Copilot's findings

  • Files reviewed: 1/23 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants