Repository navigation
Revert goproxy 1.8.4 bump - #138
Merged
Merged
Conversation
JamieMagee
approved these changes
Jun 9, 2026
There was a problem hiding this comment.
Pull request overview
Reverts the github.com/elazarl/goproxy upgrade to v1.8.4 by pinning the dependency back to the prior pseudo-version and updating the vendored goproxy sources accordingly, aiming to resolve Cargo sparse-index failures observed after the bump.
Changes:
- Downgrade
github.com/elazarl/goproxyfromv1.8.4back tov0.0.0-20240726154733-8b0c20506380ingo.mod/go.sum. - Refresh vendored module metadata (
vendor/modules.txt) and vendored goproxy code to match the reverted version. - Remove vendored goproxy internal packages/files that were introduced by the bumped version.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Re-pins goproxy dependency back to the pre-bump pseudo-version. |
| go.sum | Removes v1.8.4 checksums and restores checksums for the reverted goproxy version (and related entries). |
| vendor/modules.txt | Updates vendored module list to reflect reverted goproxy version and package list. |
| vendor/github.com/elazarl/goproxy/.golangci.yml | Removes vendored linter config from the bumped goproxy version. |
| vendor/github.com/elazarl/goproxy/README.md | Restores the vendored README content consistent with the reverted version. |
| vendor/github.com/elazarl/goproxy/actions.go | Restores handler interface docs/formatting consistent with reverted version. |
| vendor/github.com/elazarl/goproxy/certs.go | Restores CA/init and TLS defaults consistent with reverted version. |
| vendor/github.com/elazarl/goproxy/chunked.go | Adds vendored chunked writer used by the reverted HTTPS MITM response path. |
| vendor/github.com/elazarl/goproxy/counterecryptor.go | Moves signer RNG helper into the main goproxy package and adjusts key support. |
| vendor/github.com/elazarl/goproxy/ctx.go | Restores ProxyCtx and logging/charset behavior consistent with reverted version. |
| vendor/github.com/elazarl/goproxy/dispatcher.go | Restores request/response condition helpers consistent with reverted version. |
| vendor/github.com/elazarl/goproxy/doc.go | Restores vendored package documentation formatting/content. |
| vendor/github.com/elazarl/goproxy/h2.go | Restores HTTP/2 transport/proxying implementation consistent with reverted version. |
| vendor/github.com/elazarl/goproxy/http.go | Removes the v1.8.4 HTTP handling implementation (moved/changed in reverted version). |
| vendor/github.com/elazarl/goproxy/https.go | Restores CONNECT/MITM and upstream proxy-dial behavior consistent with reverted version. |
| vendor/github.com/elazarl/goproxy/logger.go | Restores Logger interface typing used by the reverted version. |
| vendor/github.com/elazarl/goproxy/proxy.go | Restores core proxy implementation consistent with reverted version. |
| vendor/github.com/elazarl/goproxy/responses.go | Restores response helper implementation consistent with reverted version. |
| vendor/github.com/elazarl/goproxy/signer.go | Adds/relocates certificate signing implementation used by reverted MITM flow. |
| vendor/github.com/elazarl/goproxy/websocket.go | Restores WebSocket proxying/handshake implementation consistent with reverted version. |
| vendor/github.com/elazarl/goproxy/internal/http1parser/header.go | Removes bumped-version HTTP/1 header parser internals. |
| vendor/github.com/elazarl/goproxy/internal/http1parser/request.go | Removes bumped-version HTTP/1 request reader internals. |
| vendor/github.com/elazarl/goproxy/internal/signer/signer.go | Removes bumped-version signer internals (replaced by top-level signer logic). |
Copilot's findings
- Files reviewed: 1/23 changed files
- Comments generated: 0
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Reverts #131, which bumped
github.com/elazarl/goproxyto1.8.4.After the deployed proxy tag containing that bump, Cargo jobs started failing while downloading sparse-index entries from
index.crates.iowith:We reproduced the failing Cargo job through the Dependabot proxy path, then reran the same job using the pre-#131 proxy tag and it completed successfully. That points to the goproxy bump as the likely regression source rather than the Cargo image.
Validation
The same Cargo job was also replayed successfully with the pre-#131 proxy image.