Repository navigation
egress(allowlist): add adsbynimbus-public.s3.amazonaws.com - #322
Merged
v-robaiken merged 1 commit intoOct 16, 2026
Merged
Conversation
v-robaiken
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This change adds the exact public Ads By Nimbus S3 host, adsbynimbus-public.s3.amazonaws.com, to the default egress allowlist.
This is required because the host is serving public package/assets content and is being blocked by the shared egress allowlist in enforce mode. The host is a fixed public S3 bucket and should be allowlisted as an exact hostname only, not widened to a suffix or glob pattern.
Anything you want to highlight for special attention from reviewers?
This host is added as an exact entry rather than a wildcard or leading-dot form to match the project’s security model for shared object storage. A broader match would risk allowing attacker-controlled sibling buckets or subdomains under the same parent namespace.
The change also includes a guardrail regression test to ensure the exact host remains exact and does not widen to a broader domain match in the future.
Google Play Store SDK Listing - https://play.google.com/sdks/details/com-adsbynimbus-android-nimbus
iOS Swift Package - https://github.com/adsbynimbus/nimbus-ios-sdk
How will you know you've accomplished your goal?
The allowlist change is validated by the egress allowlist tests, including:
Checklist