Skip to content

egress(allowlist): add adsbynimbus-public.s3.amazonaws.com #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-robaiken merged 1 commit into from
Oct 16, 2026
Merged

egress(allowlist): add adsbynimbus-public.s3.amazonaws.com #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/handlers/egress_allowlist_defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ shared_registry_domains:
# Public mirrors (continued).
- mirrors.cloud.tencent.com
- mirrors.huaweicloud.com
# AdsByNimbus public vendor (Gradle and Swift Package Manager).
- adsbynimbus-public.s3.amazonaws.com

# registry_redirect_derivations are storage hosts that a configured registry
# 302-redirects package downloads to, but that appear in no credential field.
Expand Down
3 changes: 3 additions & 0 deletions internal/handlers/egress_allowlist_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,7 @@ func TestEgressAllowlist_NewExactDomainsAllowed(t *testing.T) {
"https://maven.google.com/androidx/pkg.pom",
"https://packages.drupal.org/8/packages.json",
"https://packages.confluent.io/maven/pkg.jar",
"https://adsbynimbus-public.s3.amazonaws.com/iOS/spm/collection.json",
} {
assert.Nil(t, egressResult(t, h, allowed), "new exact host allowed: "+allowed)
}
Expand All @@ -606,6 +607,7 @@ func TestEgressAllowlist_PublicRegistriesAllowed(t *testing.T) {
"https://go.googlesource.com/tools",
"https://android.googlesource.com/platform",
"https://nodejs.org/dist/index.json",
"https://adsbynimbus-public.s3.amazonaws.com/android/sdks",
} {
assert.Nil(t, egressResult(t, h, allowed), "public registry host allowed: "+allowed)
}
Expand Down Expand Up @@ -757,6 +759,7 @@ func TestEgressAllowlist_NewEntriesDoNotWidenBeyondExactHosts(t *testing.T) {
"https://evil.charts.wiz.io/payload",
"https://evil.wiz-sec.github.io/payload",
"https://evil.fluent.github.io/payload",
"https://evil.adsbynimbus-public.s3.amazonaws.com/payload",
}

// Sibling hosts: names sharing a parent with an added entry. These pin the
Expand Down
Loading