Skip to content

fix(rulesets): restrict release tag creation in agent-plugins too - #937

Merged
devantler merged 1 commit into
mainfrom
claude/release-tag-creation-agent-plugins
Nov 14, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/release-tag-creation-agent-plugins

Conversation

@devantler

@devantler devantler commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Why

#930 restricted who may create release tags, with a separate rule for agent-plugins that let its release workflow's built-in token create the tag. GitHub does not accept that built-in identity as an exception in an organization rule, so the agent-plugins rule was never created and keeps failing to apply.

What

agent-plugins now creates its release tag with the organization's release App, like every other product. This removes the agent-plugins exception and its unused rule, so one rule covers every repository. The guard test now pins that single rule and rejects any exception coming back.

Part of #924

Deletion-Acknowledged: OrganizationRuleset.enterprise.github.m.upbound.io/restrict-agent-plugins-release-tag-creation

The removed rule never existed in GitHub (every create attempt was refused), so pruning it changes nothing in the live organization.

⚠️ Merge order: land devantler-tech/agent-plugins#711 first. Until then agent-plugins still creates its tag with the built-in token, and this change would block its next release.
👉 After merge: the change takes effect with this repository's next release, when the platform applies it.

🤖 Generated with Claude Code

GitHub refuses the built-in GitHub Actions integration as a bypass actor in
an organization ruleset (HTTP 422), so the agent-plugins-only creation
ruleset from #930 was never created and agent-plugins stayed outside the
creation restriction. agent-plugins now creates its release tag with
botantler-1 (devantler-tech/agent-plugins#711), which the organization-wide
ruleset already allows. Drop the exclusion and the unused ruleset, so one
ruleset covers every repository.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-code-quality

github-code-quality Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main 941b45b claude/release-tag-c... 0c8ef53 +/-
50% 50% 0%

C# / code-coverage/dotnet

main 941b45b claude/release-tag-c... 0c8ef53 +/-
100% 100% 0%

Go / code-coverage/go

main 941b45b claude/release-tag-c... 0c8ef53 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 14, 2026 22:55 UTC

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The release-tag creation configuration now uses one ruleset across all repositories, including agent-plugins. The separate agent-plugins ruleset and its resource reference are removed. Documentation identifies the release Apps and organization administrators as allowed creators, and the tests check that the single ruleset has no agent-plugins exclusion.

Possibly related issues

  • devantler-tech/.github issue 936 — The change updates the release-tag creation ruleset coverage that this issue discusses.
  • devantler-tech/.github issue 924 — The change applies the release-tag creation restriction to agent-plugins as part of the requested scope.
  • devantler-tech/.github issue 933 — The change consolidates the rulesets and documents botantler-1 for agent-plugins, addressing part of the issue’s scope.
Merge Risk: Low · up to 0c8ef

This consolidates release-tag creation into one organization-wide rule. The agent-plugins release workflow must already create tags with the release App before this takes effect. Otherwise its next release will be blocked, so confirm that devantler-tech/agent-plugins#711 has landed before merging. The block would be immediately visible and easy to revert.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: agent-plugins release tag creation is now restricted under the organization rule, like other products. It matches the changeset, which removes the agent-plugins except…
Description check Passed The description explains the why (the agent-plugins rule could not be created because GitHub rejects the built-in token as an organization-rule exception) and the what (agent-plugins uses the release …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: agent-plugins release tag creation is now restricted under the organization rule, like other products. It matches the changeset, which removes the agent-plugins exception and its separate ruleset and folds the rule into one repository-wide ruleset. The title's prefix 'fix(rulesets)' is a conventional-commit style that fits the change.

Full details: Description check

Explanation

The description explains the why (the agent-plugins rule could not be created because GitHub rejects the built-in token as an organization-rule exception) and the what (agent-plugins uses the release App, the exception and unused rule are removed, and the guard test is updated). It also gives merge-order and deletion notes that match the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 986a680 and 0c8ef53.

Files selected for processing: 6

  • deploy/organization-rulesets/README.md
  • deploy/organization-rulesets/kustomization.yaml
  • deploy/organization-rulesets/protect-release-tags.yaml
  • deploy/organization-rulesets/restrict-agent-plugins-release-tag-creation.yaml
  • deploy/organization-rulesets/restrict-release-tag-creation.yaml
  • tests/release-tag-creation-ruleset.sh
Files with no reviewable changes: 2

  • deploy/organization-rulesets/kustomization.yaml
  • deploy/organization-rulesets/restrict-agent-plugins-release-tag-creation.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 13

  • GitHub Check: [Test] Native Go Cache Policy
  • GitHub Check: CodeRabbit
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 📊 Code Coverage
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 🧹 Lint - golangci-lint
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 🏗️ Build
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 🧹 Lint - mega-linter
  • GitHub Check: [Test] Enable Auto-Merge - Queue Slot 3
  • GitHub Check: [Test] Enable Auto-Merge - Queue Slot 2
  • GitHub Check: [Test] Enable Auto-Merge - Queue Slot 1
  • GitHub Check: [Test] Fix Exporter - clean
  • GitHub Check: [Test] Govulncheck Allowlist - Strict Path Blocks (1.25.14, govulncheck-allowlist)
  • GitHub Check: [Test] Lint - Root Configuration
  • GitHub Check: [Test] Validate Go Project - Test Gate Blocks
Additional context used

Code guidelines: 2

deploy/organization-rulesets/README.md — auto-discovered
AGENTS.md — auto-discovered
Path-based instructions: 2

Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) The existing organization CodeQL finding rule is imported Observe-only.

CodeRabbit inference engine (deploy/organization-rulesets/README.md)

Files:

  • deploy/organization-rulesets/protect-release-tags.yaml
  • deploy/organization-rulesets/restrict-release-tag-creation.yaml
Source excerpt: **Manage GitHub declaratively — never imperatively.**

CodeRabbit inference engine (AGENTS.md)

Files:

  • deploy/organization-rulesets/protect-release-tags.yaml
  • deploy/organization-rulesets/restrict-release-tag-creation.yaml
Additional comments: 1

deploy/organization-rulesets/restrict-release-tag-creation.yaml: 1

61-61: Functional Correctness

The conditional failure path is statically sound, but the rollout risk cannot be decided from this repository. Whether agent-plugins#711 has merged, and which identity its effective release-please.yaml uses for the tag-creating step, is outside the available evidence. Confirm both before this exclusion is removed. A merged #711 with botantler-1 passed to the tag-creating step, not only to checkout, resolves the concern.

@devantler devantler closed this Nov 14, 2026
@devantler devantler reopened this Nov 14, 2026
@devantler
devantler marked this pull request as ready for review November 14, 2026 23:05
@devantler
devantler merged commit cc69bb2 into main Nov 14, 2026
682 of 688 checks passed
@devantler
devantler deleted the claude/release-tag-creation-agent-plugins branch November 14, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant