Repository navigation
fix(publish-app): refuse release tags with build metadata - #949
Conversation
The own-release signer identity carries the full tag, and the platform's own-release grammar has no build suffix, so a v1.2.3+build.5 release would publish with a signature the platform rejects. Two such tags would also collide on the same OCI version. Refuse them at admission instead. Refs devantler-tech/platform#6378 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai review |
Action performed
|
Code coverage overviewLanguages: Go, C# Go / code-coverage/test
C# / code-coverage/dotnet
Go / code-coverage/go
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
|
No actionable comments were generated in the recent review. Walkthrough
Severity of issue fixed: Medium Merge Risk:
|
Readiness at
|
Why
A product that signs its own release could tag it with build metadata, such as
v1.2.3+build.5. The release publishes, but the platform's check for who signed it does not accept that tag form, so the platform would refuse its own product's release. Two such tags would also overwrite one published version.What
The release step now stops a tag with build metadata before anything is published, and its message says how to tag the release instead. Plain versions and pre-releases publish as before. The shared publishing workflows are not affected, because their signature does not include the tag.
Fixes #948