Skip to content

fix(publish-app): refuse release tags with build metadata - #949

Merged
devantler merged 1 commit into
mainfrom
claude/publish-app-reject-build-metadata-6378
Nov 16, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/publish-app-reject-build-metadata-6378

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

A product that signs its own release could tag it with build metadata, such as v1.2.3+build.5. The release publishes, but the platform's check for who signed it does not accept that tag form, so the platform would refuse its own product's release. Two such tags would also overwrite one published version.

What

The release step now stops a tag with build metadata before anything is published, and its message says how to tag the release instead. Plain versions and pre-releases publish as before. The shared publishing workflows are not affected, because their signature does not include the tag.

Fixes #948

The own-release signer identity carries the full tag, and the platform's
own-release grammar has no build suffix, so a v1.2.3+build.5 release would
publish with a signature the platform rejects. Two such tags would also
collide on the same OCI version. Refuse them at admission instead.

Refs devantler-tech/platform#6378

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-code-quality

github-code-quality Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main a3f8fa3 claude/publish-app-r... f428f09 +/-
50% 50% 0%

C# / code-coverage/dotnet

main a3f8fa3 claude/publish-app-r... f428f09 +/-
100% 100% 0%

Go / code-coverage/go

main a3f8fa3 claude/publish-app-r... f428f09 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 16, 2026 01:29 UTC

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The publish-app action now rejects release tags with SemVer build metadata. It validates tags containing a version and an optional prerelease, and sets the version output to the accepted tag without its leading v. Tests cover rejected metadata cases and accepted stable and prerelease tags. The README and action output description reflect the updated behavior.

Possibly related issues

  • Issue 926 — The issue depends on the publish-app composite action, which this PR changes, but it does not specifically concern build-metadata tag admission.

Severity of issue fixed: Medium

Merge Risk: Minimal · up to f428f

The action now refuses release tags with build metadata and keeps publishing plain and prerelease tags as before. No merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the publish-app action now refuses release tags that contain SemVer build metadata. The raw summary confirms admit.sh now rejects '+' build metadata, and the README, a…
Description check Passed The description explains the problem: build-metadata tags such as v1.2.3+build.5 would publish but fail the platform's signature check and could overwrite an existing version. It states the change: th…
Linked Issues check Passed Issue #948 has three coding acceptance criteria. (1) Refusal before registry contact with a tag-guidance message: in head admit.sh, check_release_tag runs before check_signer_identity, check_checkout,…
Out of Scope Changes check Passed The changed files are actions/publish-app/admit.sh, actions/publish-app/action.yaml, actions/publish-app/README.md and .github/tests/test-publish-app-action.sh. Each one supports the build-metadata re…
Full details: Title check

Explanation

The title names the main change: the publish-app action now refuses release tags that contain SemVer build metadata. The raw summary confirms admit.sh now rejects '+' build metadata, and the README, action.yaml, and tests were updated to match. The title is specific and concise, and it fits the linked objective of refusing such tags before publishing.

Full details: Description check

Explanation

The description explains the problem: build-metadata tags such as v1.2.3+build.5 would publish but fail the platform's signature check and could overwrite an existing version. It states the change: the release step stops such tags before publishing and tells the user how to tag instead. It also notes that plain versions and pre-releases still publish and that shared workflows are unaffected. It is on topic and references issue #948.

Full details: Linked Issues check

Explanation

Issue #948 has three coding acceptance criteria. (1) Refusal before registry contact with a tag-guidance message: in head admit.sh, check_release_tag runs before check_signer_identity, check_checkout, check_default_branch and every registry step. Its first match is case "$tag" in *+*), which fails with "the release tag $tag carries build metadata; tag the release as vMAJOR.MINOR.PATCH[-PRERELEASE] without a +BUILD suffix". All checks in check_inputs and check_release_tag are local and make no network or registry call. (2) Plain and pre-release admission: the semver regex ^v${num}\.${num}\.${num}(-${pre}(\.${pre})*)?$ admits plain and pre-release tags. version is still set to the tag without the leading v, and it is written to GITHUB_OUTPUT as before. (3) Tests: the test script header and its summary state that build-metadata tags are refused, including malformed metadata, and that the length cases now use an overlong prerelease. I could not read the full test file, because the output was truncated. I also could not read the base blob, so I did not confirm that the tests fail against the previous admission. The source evidence establishes criteria (1) and (2). Criterion (3) is supported by the summary and the test header, but not verified by execution.

Full details: Out of Scope Changes check

Explanation

The changed files are actions/publish-app/admit.sh, actions/publish-app/action.yaml, actions/publish-app/README.md and .github/tests/test-publish-app-action.sh. Each one supports the build-metadata refusal from #948. admit.sh holds the refusal and the removal of build-metadata stripping. action.yaml and README.md change the documented version output and refusal behavior. The test script changes the build-metadata and length cases. The PR description states that shared publishing workflows are not affected, and no changed file falls outside the publish-app action or its test. I found no unrelated change.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between a3f8fa3 and f428f09.

Files selected for processing: 4

  • .github/tests/test-publish-app-action.sh
  • actions/publish-app/README.md
  • actions/publish-app/action.yaml
  • actions/publish-app/admit.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 118

  • GitHub Check: [Test] Validate Go Project / 🧪 Test
  • GitHub Check: [Test] Validate Go Project / 📦 Tidy
  • GitHub Check: [Test] Validate Go Project / 🏗️ Build
  • GitHub Check: [Test] Validate Go Project / 🧹 Lint - golangci-lint
  • GitHub Check: [Test] Validate Go Project / 🛡️ Vulnerability Scan
  • GitHub Check: [Test] Validate Go Project / 🧹 Lint - mega-linter
  • GitHub Check: [Test] Validate Go Project / 📊 Code Coverage
  • GitHub Check: [Test] Validate Go Project / 🔍 Dead Code Analysis
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 🧹 Lint - golangci-lint
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 🧹 Lint - mega-linter
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 🛡️ Vulnerability Scan
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 🔍 Dead Code Analysis
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 🧪 Test
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 📊 Code Coverage
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 🏗️ Build
  • GitHub Check: [Test] Validate Go Project - Manual Workflow Fixes Opted In / 📦 Tidy
  • GitHub Check: [Test] Validate Go Project - Signed Fixes Suppressed / 📊 Code Coverage
  • GitHub Check: [Test] Validate Go Project - Signed Fixes Suppressed / 🔍 Dead Code Analysis
  • GitHub Check: [Test] Validate Go Project - Signed Fixes Suppressed / 🧹 Lint - golangci-lint
  • GitHub Check: [Test] Validate Go Project - Signed Fixes Suppressed / 🏗️ Build
  • GitHub Check: [Test] Validate Go Project - Signed Fixes Suppressed / 🧪 Test
  • GitHub Check: [Test] Validate Go Project - Signed Fixes Suppressed / 🧹 Lint - mega-linter
  • GitHub Check: [Test] Validate Go Project - Signed Fixes Suppressed / 🛡️ Vulnerability Scan
  • GitHub Check: [Test] Validate Go Project - Signed Fixes Suppressed / 📦 Tidy
  • GitHub Check: [Test] Validate Go Project - Isolated PostgreSQL / 📊 Code Coverage
  • GitHub Check: [Test] Validate Go Project - Isolated PostgreSQL / 🛡️ Vulnerability Scan
  • GitHub Check: [Test] Validate Go Project - Isolated PostgreSQL / 🔍 Dead Code Analysis
  • GitHub Check: [Test] Validate Go Project - Isolated PostgreSQL / 🧹 Lint - golangci-lint
  • GitHub Check: [Test] Validate Go Project - Isolated PostgreSQL / 🧹 Lint - mega-linter
  • GitHub Check: [Test] Validate Go Project - Isolated PostgreSQL / 📦 Tidy
  • GitHub Check: [Test] Validate Go Project - Isolated PostgreSQL / 🧪 Test
  • GitHub Check: [Test] Validate Go Project - Isolated PostgreSQL / 🏗️ Build
  • GitHub Check: [Test] Validate Go Project - Default-Branch Test Opted Out / 🏗️ Build
  • GitHub Check: [Test] Validate Go Project - Default-Branch Test Opted Out / 🧹 Lint - mega-linter
  • GitHub Check: [Test] Validate Go Project - Default-Branch Test Opted Out / 📊 Code Coverage
  • GitHub Check: [Test] Validate Go Project - Default-Branch Test Opted Out / 🧪 Test
  • GitHub Check: [Test] Validate Go Project - Default-Branch Test Opted Out / 🛡️ Vulnerability Scan
  • GitHub Check: [Test] Validate Go Project - Default-Branch Test Opted Out / 📦 Tidy
  • GitHub Check: [Test] Validate Go Project - Default-Branch Test Opted Out / 🧹 Lint - golangci-lint
  • GitHub Check: [Test] Validate Go Project - Default-Branch Test Opted Out / 🔍 Dead Code Analysis
  • GitHub Check: [Test] Enable Auto-Merge - Queue Slot 3
  • GitHub Check: [Test] Enable Auto-Merge - Queue Slot 2
  • GitHub Check: [Test] Enable Auto-Merge - Queue Slot 1
  • GitHub Check: [Test] Govulncheck Allowlist - Strict Path Blocks (1.26.9, govulncheck-allowlist)
  • GitHub Check: [Test] Fix Exporter - ordinary
  • GitHub Check: [Test] Run .NET Tests (macos-latest)
  • GitHub Check: [Test] Fix Exporter - manual
  • GitHub Check: [Test] Run .NET Tests (windows-latest)
  • GitHub Check: [Test] Lint - Root Configuration
  • GitHub Check: [Test] Fix Exporter - read-only
  • GitHub Check: [Test] Fix Exporter - clean
  • GitHub Check: [Test] Govulncheck Allowlist - Strict Path Blocks (1.27.2, govulncheck-allowlist)
  • GitHub Check: [Test] Enable Auto-Merge - Author Gate
  • GitHub Check: [Test] Govulncheck Allowlist - Strict Path Blocks (1.26.9, govulncheck-generics)
  • GitHub Check: [Test] Govulncheck Allowlist - Strict Path Blocks (1.25.14, govulncheck-generics)
  • GitHub Check: [Test] Run .NET Tests (ubuntu-latest)
  • GitHub Check: [Test] Fix Exporter - export-failure
  • GitHub Check: [Test] Govulncheck Allowlist - Strict Path Blocks (1.27.2, govulncheck-generics)
  • GitHub Check: [Test] Validate Go Project - Lint Gate Blocks
  • GitHub Check: [Test] Govulncheck Allowlist - Strict Path Blocks (1.25.14, govulncheck-allowlist)
  • GitHub Check: [Test] Zizmor - Blocks On Vulnerable Fixture
  • GitHub Check: [Test] Govulncheck Allowlist - Allowlisted Advisory Passes (1.26.9, govulncheck-allowlist)
  • GitHub Check: [Test] Release PR Lifecycle Guard
  • GitHub Check: [Test] Govulncheck Allowlist - Allowlisted Advisory Passes (1.26.9, govulncheck-generics)
  • GitHub Check: [Test] Govulncheck Allowlist - Allowlisted Advisory Passes (1.27.2, govulncheck-allowlist)
  • GitHub Check: [Test] Govulncheck Allowlist - Allowlisted Advisory Passes (1.25.14, govulncheck-allowlist)
  • GitHub Check: [Test] Go workflow guards
  • GitHub Check: [Test] Govulncheck - A Timed-Out Scan Is Retried Once
  • GitHub Check: [Test] Govulncheck Allowlist - Allowlisted Advisory Passes (1.25.14, govulncheck-generics)
  • GitHub Check: [Test] Govulncheck Allowlist - Allowlisted Advisory Passes (1.27.2, govulncheck-generics)
  • GitHub Check: [Test] Enable Auto-Merge - Pentad Gate
  • GitHub Check: [Test] Validate Go Project - Test Gate Blocks
  • GitHub Check: [Test] Validate Go Project - Invocation-Aware Concurrency Key
  • GitHub Check: [Test] Go Suite Trigger Guard - Blocks On Bad Input
  • GitHub Check: [Test] Go Lint - Source and Credential Boundaries
  • GitHub Check: [Test] Validate Go Project - Gate Lockstep
  • GitHub Check: [Test] Run .NET Tests - Microsoft.Testing.Platform (ubuntu-latest)
  • GitHub Check: [Test] Go Suite - Default-Branch Trigger Coverage
  • GitHub Check: [Test] Govulncheck Allowlist - Gate Uses Self-Tested Implementation
  • GitHub Check: [Test] Govulncheck - Timeout & Memory Safety Controls
  • GitHub Check: [Test] Run .NET Tests - Microsoft.Testing.Platform (macos-latest)
  • GitHub Check: [Test] Run .NET Tests - Gate Blocks
  • GitHub Check: [Test] Enable Auto-Merge on PR - Credential-Free CI
  • GitHub Check: [Test] Run .NET Tests - Microsoft.Testing.Platform (windows-latest)
  • GitHub Check: [Test] Zizmor - Gate Pins Self-Tested Action
  • GitHub Check: test-run-dotnet-tests (macos-latest)
  • GitHub Check: test-dependency-review
  • GitHub Check: test-setup-ksail-cli (ubuntu-latest)
  • GitHub Check: [Test] Create Release - Least Privilege
  • GitHub Check: test-setup-ksail-cli (macos-latest)
  • GitHub Check: test-run-dotnet-tests (windows-latest)
  • GitHub Check: test-login-to-ghcr-empty-token
  • GitHub Check: test-publish-app
  • GitHub Check: test-run-dotnet-tests (ubuntu-latest)
  • GitHub Check: test-upload-coverage
  • GitHub Check: test-diagnose-flux
  • GitHub Check: [Test] Run .NET Tests - Gate Lockstep
  • GitHub Check: test-retry-script
  • GitHub Check: test-aggregate-job-checks-success
  • GitHub Check: test-setup-go-toolchain (windows-latest)
  • GitHub Check: test-setup-go-toolchain-private-modules
  • GitHub Check: [Test] Run .NET Tests - Preserve Source Mapping
  • GitHub Check: test-setup-go-toolchain (macos-latest)
  • GitHub Check: test-setup-go-toolchain (ubuntu-latest)
  • GitHub Check: test-free-disk-space
  • GitHub Check: test-aggregate-job-checks-unknown
  • GitHub Check: [Test] Retired Repository Links - Enabled (macos-latest)
  • GitHub Check: [Test] Retired Repository Links - Enabled (ubuntu-latest)
  • GitHub Check: [Test] Validate Shell Pipelines (macos-latest)
  • GitHub Check: [Test] Validate Shell Pipelines (ubuntu-latest)
  • GitHub Check: [Test] Validate Naming (ubuntu-latest)
  • GitHub Check: [Test] Validate Naming (macos-latest)
  • GitHub Check: CodeRabbit
  • GitHub Check: 🧹 Validate manifests
  • GitHub Check: test-publish-contracts
  • GitHub Check: [Test] Run .NET Tests - Authenticated Packages (windows-latest)
  • GitHub Check: lint-ci-coverage-parity
  • GitHub Check: [Test] TODO Scanner - Isolated Image
Additional context used

Code guidelines: 3

actions/CONTRIBUTING.md — auto-discovered
AGENTS.md — auto-discovered
CONTRIBUTING.md — auto-discovered
Path-based instructions: 3

Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) Full detail in [actions/CONTRIBUTING.md](actions/CONTRIBUTING.md).

CodeRabbit inference engine (actions/CONTRIBUTING.md)

Files:

  • .github/tests/test-publish-app-action.sh
Source excerpt: Full detail in [actions/CONTRIBUTING.md](actions/CONTRIBUTING.md).

CodeRabbit inference engine (AGENTS.md)

Files:

  • actions/publish-app/README.md
  • actions/publish-app/action.yaml
  • actions/publish-app/admit.sh
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) Three things share one repo: **The org's public profile** — `profile/README.md` (rendered on the org page), plus the org-wide community health files i...

CodeRabbit inference engine (CONTRIBUTING.md)

Files:

  • .github/tests/test-publish-app-action.sh

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at f428f095fcb7dc0306c4fbe07930c1fef847d42d:

  • CI: all required checks green (186 success, 54 skipped), merge state CLEAN, 0 unresolved threads.
  • Review: CodeRabbit finding-free at this head.
  • Tried as a caller: ran this head's admit.sh with release refs v1.2.3+abc, v1.2.3 and v1.2.3-rc.1. The build-metadata tag is refused with the message telling the caller to drop the +BUILD suffix; both plain and pre-release tags pass the tag check and stop only at the later checkout check, as expected with no checkout present.

@devantler
devantler marked this pull request as ready for review November 16, 2026 02:20
@devantler
devantler merged commit 684b506 into main Nov 16, 2026
241 checks passed
@devantler
devantler deleted the claude/publish-app-reject-build-metadata-6378 branch November 16, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

publish-app admits release tags the platform cannot verify

1 participant