Skip to content

refactor(release): cut marketplace releases with release-please - #708

Merged
devantler merged 2 commits into
mainfrom
claude/release-please-705
Nov 14, 2026
Merged

devantler merged 2 commits into
mainfrom
claude/release-please-705

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

#705 part 1. The custom marketplace release system is about 4.4k lines: prepare, propose and publish workflows, two hourly crons and ~25 scripts. It produced about five releases in 60 days. release-please does the same job natively, and the release proposal becomes an ordinary reviewable PR.

Design (maintainer delegated the choice; analysis in #705)

  • One release-please component, the root (.), release-type simple. Tags stay vX.Y.Z.
    • devantler-tech/update-agent-skills-action's CI reads this repo's releases/latest and requires ^v\d+\.\d+\.\d+$. One component per plugin would make the latest release e.g. ksail-v1.0.3 and break it.
    • Plugin versions are cache keys that authors already bump in each PR. check-plugin-version-bump.sh and plugin-changelog.sh keep enforcing that unchanged.
  • extra-files with jsonpath: $.metadata.version bumps both marketplace manifests. They are still identical until part 2 drops .github/plugin/. The rewrite was reproduced locally: only the version line changes.
  • skip-changelog: true. The release notes go into the release PR and the GitHub release; the per-plugin changelogs stay the only history.
  • Workflow release-please.yaml (push to main):
    • release runs with the workflow token (contents, pull-requests: write). It tags and publishes a merged release PR. GitHub Actions creates the tag, which fits feat(rulesets): let only the release process create release tags .github#930's rule that only GitHub Actions may create v* tags here.
    • release-pr runs with the App token so the release PR's CI starts, and only after release. release-please refuses to open the next PR while a merged one is untagged.
    • The action is pinned to v5.0.0 (Node 24).
  • Bootstrapped at 2.2.0 (the latest release). The first release PR should propose 2.3.0 for feat(agentic-engineering): bundle Numina's MCP server and Stripe skill #697 and feat(agentic-engineering): make a parked PR owned work, never a terminal state #699.

Removed

  • The prepare, propose and publish workflows, and the PR-only marketplace version gate.
  • The test-marketplace CI job, which had nothing left to run.
  • About 25 release-only scripts, tests and jq libraries.
  • scripts/marketplace-release.jq is trimmed to the two definitions the manifest validator still uses.
  • Libraries that surviving scripts still use are kept.
  • The repo variables MARKETPLACE_AUTOPROPOSE and MARKETPLACE_AUTOPUBLISH become unused. Settings are unchanged.

Lost

The custom check that tied a release to one specific successful main CI run. The release PR now passes the normal required checks and the merge queue, which tests the exact merge result, and GitHub releases are immutable.

Validation

  • actionlint reports only an existing concurrency.queue finding in update-agent-skills.yaml.
  • zizmor (including pedantic on the new workflow) is clean, and so are validate-manifests.sh, check-skill-authoring.sh, check-skill-licenses.sh, shellcheck and check-instruction-size.sh.
  • 30 of the remaining 31 script tests pass. recheck-open-prs-observations.test.sh fails the same two cases on unmodified main, locally only; refactor(ci): replace recheck-open-prs with the merge queue #707 deletes it.
  • Not run: release-please itself, which cannot run offline. The first real release PR is its first live test.

Before ready

This changes how releases are cut, so it stays a draft until the maintainer approves.

Part of #705.

🤖 Generated with Claude Code

Replace the custom preparation, proposal and publication workflows and
their scripts with release-please (#705, part 1 of 2). One root package
bumps .metadata.version in both marketplace manifests through a reviewable
release PR opened with the App token; merging it tags vX.Y.Z and publishes
the GitHub release with the workflow token. Per-plugin version and
changelog gates are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: 316ba0c

  • CodeRabbit: review limit reached on agent-plugins since 2026-11-14T19:14:34Z ("Review limit reached"); no review delivered for this PR
  • Codex: account usage limit since 2026-11-14T12:19:01Z (devantler-tech/ksail#8183), review-lane-health DOWN
  • Cursor Bugbot: team usage limit since 2026-11-14T03:47:50Z (devantler-tech/platform#6244)

Verdict: no P0/P1 findings

🤖 Generated with Claude Code

…-705

# Conflicts:
#	.github/workflows/propose-marketplace-release.yaml
#	README.md
#	docs/marketplace-releases.md
#	docs/scripts.md
#	scripts/ci-script-test-sharding-workflow.test.sh
#	scripts/marketplace-proposal-workflow.test.sh

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: edf68f2

  • CodeRabbit: review limit reached on agent-plugins since 2026-11-14T19:14:34Z ("Review limit reached"); no review delivered for this PR
  • Codex: account usage limit since 2026-11-14T12:19:01Z (devantler-tech/ksail#8183), review-lane-health DOWN
  • Cursor Bugbot: team usage limit since 2026-11-14T03:47:50Z (devantler-tech/platform#6244)

Verdict: no P0/P1 findings

🤖 Generated with Claude Code

@devantler
devantler marked this pull request as ready for review November 14, 2026 21:11
@devantler
devantler added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit e714a4e Nov 14, 2026
23 checks passed
@devantler
devantler deleted the claude/release-please-705 branch November 14, 2026 21:34
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant