Repository navigation
refactor(release): cut marketplace releases with release-please - #708
Merged
Merged
Conversation
Replace the custom preparation, proposal and publication workflows and their scripts with release-please (#705, part 1 of 2). One root package bumps .metadata.version in both marketplace manifests through a reviewable release PR opened with the App token; merging it tags vX.Y.Z and publishes the GitHub release with the workflow token. Per-plugin version and changelog gates are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
devantler
commented
Nov 14, 2026
devantler
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer (interactive Claude Code session)
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: 316ba0c
- CodeRabbit: review limit reached on agent-plugins since 2026-11-14T19:14:34Z ("Review limit reached"); no review delivered for this PR
- Codex: account usage limit since 2026-11-14T12:19:01Z (devantler-tech/ksail#8183), review-lane-health DOWN
- Cursor Bugbot: team usage limit since 2026-11-14T03:47:50Z (devantler-tech/platform#6244)
Verdict: no P0/P1 findings
🤖 Generated with Claude Code
…-705 # Conflicts: # .github/workflows/propose-marketplace-release.yaml # README.md # docs/marketplace-releases.md # docs/scripts.md # scripts/ci-script-test-sharding-workflow.test.sh # scripts/marketplace-proposal-workflow.test.sh
devantler
commented
Nov 14, 2026
devantler
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer (interactive Claude Code session)
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: edf68f2
- CodeRabbit: review limit reached on agent-plugins since 2026-11-14T19:14:34Z ("Review limit reached"); no review delivered for this PR
- Codex: account usage limit since 2026-11-14T12:19:01Z (devantler-tech/ksail#8183), review-lane-health DOWN
- Cursor Bugbot: team usage limit since 2026-11-14T03:47:50Z (devantler-tech/platform#6244)
Verdict: no P0/P1 findings
🤖 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#705 part 1. The custom marketplace release system is about 4.4k lines: prepare, propose and publish workflows, two hourly crons and ~25 scripts. It produced about five releases in 60 days. release-please does the same job natively, and the release proposal becomes an ordinary reviewable PR.
Design (maintainer delegated the choice; analysis in #705)
.), release-typesimple. Tags stayvX.Y.Z.releases/latestand requires^v\d+\.\d+\.\d+$. One component per plugin would make the latest release e.g.ksail-v1.0.3and break it.check-plugin-version-bump.shandplugin-changelog.shkeep enforcing that unchanged.extra-fileswithjsonpath: $.metadata.versionbumps both marketplace manifests. They are still identical until part 2 drops.github/plugin/. The rewrite was reproduced locally: only the version line changes.skip-changelog: true. The release notes go into the release PR and the GitHub release; the per-plugin changelogs stay the only history.release-please.yaml(push to main):releaseruns with the workflow token (contents,pull-requests: write). It tags and publishes a merged release PR. GitHub Actions creates the tag, which fits feat(rulesets): let only the release process create release tags .github#930's rule that only GitHub Actions may createv*tags here.release-prruns with the App token so the release PR's CI starts, and only afterrelease. release-please refuses to open the next PR while a merged one is untagged.2.2.0(the latest release). The first release PR should propose 2.3.0 for feat(agentic-engineering): bundle Numina's MCP server and Stripe skill #697 and feat(agentic-engineering): make a parked PR owned work, never a terminal state #699.Removed
test-marketplaceCI job, which had nothing left to run.scripts/marketplace-release.jqis trimmed to the two definitions the manifest validator still uses.MARKETPLACE_AUTOPROPOSEandMARKETPLACE_AUTOPUBLISHbecome unused. Settings are unchanged.Lost
The custom check that tied a release to one specific successful main CI run. The release PR now passes the normal required checks and the merge queue, which tests the exact merge result, and GitHub releases are immutable.
Validation
actionlintreports only an existingconcurrency.queuefinding inupdate-agent-skills.yaml.zizmor(including pedantic on the new workflow) is clean, and so arevalidate-manifests.sh,check-skill-authoring.sh,check-skill-licenses.sh,shellcheckandcheck-instruction-size.sh.recheck-open-prs-observations.test.shfails the same two cases on unmodified main, locally only; refactor(ci): replace recheck-open-prs with the merge queue #707 deletes it.Before ready
This changes how releases are cut, so it stays a draft until the maintainer approves.
Part of #705.
🤖 Generated with Claude Code