Skip to content

ci(release): create the marketplace release tag with the App token - #711

Merged
devantler merged 1 commit into
mainfrom
claude/release-tag-app-token
Nov 14, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/release-tag-app-token

Conversation

@devantler

Copy link
Copy Markdown
Contributor

What

The release job in release-please.yaml now creates the vX.Y.Z tag and the GitHub release with the repository's GitHub App token (the organization APP_CLIENT_ID App, which already opens the release PR) instead of the workflow token. The job's own GITHUB_TOKEN drops to no permissions; the App token carries contents: write and pull-requests: write, the same two the job needed before.

docs/marketplace-releases.md now says the App creates the tag.

Why

devantler-tech/.github#930 restricts v* tag creation to the organization's release Apps. agent-plugins was meant to keep the workflow token through its own organization ruleset with the GitHub Actions integration as the bypass actor, but GitHub refuses that actor in an organization ruleset (HTTP 422 when the ruleset is created), so that ruleset never existed. Creating the tag with the App, which the organization-wide ruleset already allows, is the end state that ruleset's own notes planned. Once this is on main, a .github follow-up drops the agent-plugins exclusion and the unused ruleset.

Effect

  • Releases keep working exactly as now: the App can create tags here today, because agent-plugins is still excluded from the organization-wide restriction until the follow-up lands.
  • An App-created release can trigger workflows, unlike one made with the workflow token. No workflow in this repository runs on tag pushes or release events, so nothing new starts.

Validation

  • actionlint .github/workflows/release-please.yaml: no findings.
  • zizmor --offline .github/workflows/release-please.yaml: no findings.

Part of devantler-tech/.github#924.

🤖 Generated with Claude Code

Only the organization's release Apps may create v* tags. GitHub refuses the
built-in GitHub Actions integration as a bypass actor in an organization
ruleset, so the agent-plugins-only ruleset that would have let the workflow
token create the tag cannot exist. Create the tag with the repository's
GitHub App instead, which the organization-wide ruleset already allows.
No workflow here runs on tags or releases, so the App-created release
starts nothing new.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The release job now generates a GitHub App token with contents: write and pull-requests: write, then passes it to the release action. The job no longer has direct workflow-token permissions. The workflow comments and release guide state that only organization release Apps may create v* tags.

Possibly related issues

  • Issue 101: The issue covers the marketplace release pipeline and its guide. This pull request changes the release job’s token and tag policy and updates that guide.
Merge Risk: Minimal · up to f3a0a

The release workflow now creates the version tag and release with the repository's GitHub App instead of the built-in workflow token, and the guide is updated to match. No concrete defect was established. Before the repository exclusion from the organization tag ruleset is removed, confirm that the configured App is an authorized bypass actor for v* tags.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the marketplace release tag is now created with the GitHub App token in the release-please CI workflow. It matches the raw summary and the objectives, and it follows t…
Description check Passed The description explains what changed, why (organization tag restriction and the failed agent-plugins ruleset), the effect on releases and workflows, and the validation run. It matches the raw summary…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the marketplace release tag is now created with the GitHub App token in the release-please CI workflow. It matches the raw summary and the objectives, and it follows the conventional commit style. It does not cover the docs change, which is expected.

Full details: Description check

Explanation

The description explains what changed, why (organization tag restriction and the failed agent-plugins ruleset), the effect on releases and workflows, and the validation run. It matches the raw summary and the objectives.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9c75fbe2-edd0-4656-952a-af6c3c0743ab
Commits

Reviewing files that changed from the base of the PR and between e714a4e and f3a0a3f.

Files selected for processing: 2

  • .github/workflows/release-please.yaml
  • docs/marketplace-releases.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 1

  • GitHub Check: CodeRabbit
Additional context used

Code guidelines: 1

AGENTS.md — auto-discovered
Path-based instructions: 1

Source excerpt: **Least-privilege permissions.**

CodeRabbit inference engine (AGENTS.md)

Files:

  • .github/workflows/release-please.yaml
Learnings: 1

Common learnings

Learnt from: CR
Repo: devantler-tech/agent-plugins

Timestamp: 2026-11-14T22:25:50.069Z
Learning: Applicability reference:
AGENTS.md: # devantler-tech/agent-plugins
## Validation
Run before opening any PR, and never weaken a check to pass — fix the root cause. The required gate
is the aggregated **`CI - Required Checks`** job. Every validation command, what each check
observes, and how a new gate reaches pull requests that are already open are in
[docs/validation.md](docs/validation.md): **read it before validating a change, or adding or
altering a CI job.** Every change starts with:

AGENTS.md: # devantler-tech/agent-plugins
## Agent guides
| Guide | Read it before |
|---|---|
| [docs/validation.md](docs/validation.md) | validating a change, opening a PR, or adding or altering a CI job |

AGENTS.md: # devantler-tech/agent-plugins
## Maintenance (autonomous AI engineer)
**Validate before any PR:** run the steps in [docs/validation.md](docs/validation.md) (`./scripts/validate-manifests.sh`,
spec-validate each skill, `actionlint` changed workflows). No app build here — manifest parit...
Additional comments: 1

.github/workflows/release-please.yaml: 1

39-39: Data Integrity & Integration

The App bypass premise cannot be decided from the available evidence. The variable that selects the App identity and the organization ruleset details could not be read, so the claim is neither confirmed nor refuted.

@devantler
devantler marked this pull request as ready for review November 14, 2026 22:30
@devantler
devantler added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit a888140 Nov 14, 2026
23 checks passed
@devantler
devantler deleted the claude/release-tag-app-token branch November 14, 2026 22:42
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Nov 14, 2026
devantler added a commit to devantler-tech/.github that referenced this pull request Nov 14, 2026
GitHub refuses the built-in GitHub Actions integration as a bypass actor in
an organization ruleset (HTTP 422), so the agent-plugins-only creation
ruleset from #930 was never created and agent-plugins stayed outside the
creation restriction. agent-plugins now creates its release tag with
botantler-1 (devantler-tech/agent-plugins#711), which the organization-wide
ruleset already allows. Drop the exclusion and the unused ruleset, so one
ruleset covers every repository.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant