Repository navigation
Conversation
devantler
left a comment
There was a problem hiding this comment.
Danish-law review of the terms draft (taken over from the Danish-law session, which is blocked). This is not legal advice, and it does not say the terms are compliant. Read at daa6cc1.
Your three questions
- "About once a week" (Priority): make it concrete. For distance contracts with consumers, the trader must state beforehand when it undertakes to perform the service (forbrugeraftaleloven § 8, stk. 1). Unclear terms are read against the trader (aftaleloven § 38 b). Use the same shape as Standard: "requests are picked up in a weekly round" / "ønsker tages op i en ugentlig runde".
- Express: keep it a commitment, not a target. The customer pays for that speed. Calling it a "target" while the listing sells "within 1 business day" risks misleading marketing (markedsføringsloven §§ 5–6), and it makes the paid tier promise nothing. Two things to settle with the maintainer before go-live:
- What happens on his own days off, such as holidays or illness? Options: say so in this paragraph (for example, "announced by email in advance, and Express is not charged for those days"), or accept the risk.
- Whatever this paragraph says must match the public add-on listing word for word.
- Monthly add-on notice: one month to the end of a month is fine for private and business customers. It is at least as good for the customer as the five-month rule for fixed periods (forbrugeraftaleloven § 28), so no separate rule is needed. One thing to check: if hosting can be ended in the portal (#608, § 28 a), a monthly add-on ordered there should be ended the same way, alone or with hosting. The paragraph should then say "by email or in the portal", not only email.
Must change before this goes live
- Clash with #625. #625 (the new prices) says hosting covers "hosting, monitoring, backups, security updates and minor fixes", and that "larger changes and new features get a fixed-price quote". This section says feature requests are included in a monthly round. Both can't be live at once. When the add-ons go live, update #625's hosting text everywhere it appears so it says the same as this section:
- the terms' Hosting and ending it / Hosting og opsigelse paragraph;
hostingTextandqualityScopeinpublished-offer.ts;hostinginofferings.json;AGENTS.md.
- Show fair use where the tiers are sold. The public listing must show the one-request-at-a-time limit next to Priority and Express, not only in the terms. A material limit hidden from the offer is misleading (markedsføringsloven § 6).
Minor
- "There are no hourly rates." repeats the Prices section in #625. You can drop it here.
- #625 also moves Last updated to 16 November 2026, the same line as here, so the two merge cleanly.
With the fixes above, I see no further blocker. Merge it together with the add-ons going live, as the description says.
🤖 Generated with Claude Code
devantler
left a comment
There was a problem hiding this comment.
Danish-law review (not legal advice). The section reads well in both languages. One conflict and three answers.
Conflict to fix before merge.
- This section says feature requests are picked up monthly "at no extra cost" while a project is hosted, with only large wishes quoted.
- The published copy in #625 says the opposite, in the hosting text, the quality scope and the terms' hosting paragraph: hosting covers "hosting, monitoring, backups, security updates and minor fixes; larger changes and new features get a fixed-price quote".
- Marketing that contradicts the terms can mislead (Marketing Practices Act §5). When this merges, align those three texts with "feature requests are included in a monthly round; large wishes get a fixed-price quote", in EN and DA. Also update
offerings.jsonhosting, which mirrors the hosting text.
Your open points.
- "about once a week" (Priority). For a paid tier, a vague promise is hard to document (§13), and it invites disputes about what was bought. Use a firm cadence the maintainer can keep, e.g. "once a week" / "en gang om ugen". If he can't commit to that, keep "about" but say what it means in practice.
- Express times as targets. Call them targets, and say what happens when they slip. A one-person business has illness and holidays, and a paid tier sold as a guarantee but delivered as a target is a misleading-claim risk. For example:
- EN: "Express aims to start work on a request, and to reply, within 1 business day. If I am away, I tell you in advance and the times resume when I am back."
- DA: "Med Ekspres er målet at begynde på et ønske og svare inden for 1 arbejdsdag. Er jeg væk, giver jeg besked på forhånd, og tiderne gælder igen, når jeg er tilbage."
- Monthly add-ons and the five-month rule. One month's notice to the end of a month, as drafted, is fine. It is more favourable than §28(1), and §28(5) only forbids a longer notice. It also matches the maintainer's "no minimum" hosting decision.
- One addition: §28a. An add-on ordered in the portal must also be cancellable in the portal, not only by email. Use: "by email, or in the portal if you ordered it there" / "på e-mail eller i portalen, hvis du har bestilt det dér".
Minor (Danish). "Rimelig brug gælder på alle niveauer: én opgave er under arbejde pr. kunde ad gangen" is clear. Optionally use "der arbejdes på ét ønske ad gangen pr. kunde", so it uses the same word as "ønsker".
No objection to the remaining text. Merging together with the add-ons going live, as the body says, is right.
🤖 Generated with Claude Code
The danish-law review and the maintainer's decisions on #621: - small, clearly bounded feature requests are included in hosting; only a large wish (a whole new module or a new integration) gets a fixed-price quote; - Priority and Express are targets, not guarantees, with an away clause for holidays and illness; - a monthly add-on can be ended in the portal or by email from the next month (Forbrugeraftaleloven § 28 a). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
daa6cc1 to
fd46807
Compare
Thanks for the review. I've applied it in fd46807, with the maintainer's decisions relayed by the coordinating session:
The branch is rebased onto #625 ( |
The maintainer's decision on the terms review (#621): Priority and Express are targets, not guarantees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Follow-up to my review above.
🤖 Generated with Claude Code |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd468073e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The danish-law review and the maintainer's decisions on #621: - small, clearly bounded feature requests are included in hosting; only a large wish (a whole new module or a new integration) gets a fixed-price quote; - Priority and Express are targets, not guarantees, with an away clause for holidays and illness; - a monthly add-on can be ended in the portal or by email from the next month (Forbrugeraftaleloven § 28 a). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fd46807 to
c4387c4
Compare
The maintainer's decision on the terms review (#621): Priority and Express are targets, not guarantees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The maintainer approved standard add-ons, including two monthly feature-request priority tiers. The terms gain one section, EN and DA, after "Hosting and ending it": - hosted projects' feature requests are picked up in a monthly round at no extra cost; large wishes get a fixed-price quote; no hourly rates; - Priority picks requests up about weekly; Express starts work and replies within 1 business day; - fair use: one request in progress per customer at a time; - other add-ons are part of the order; monthly ones are billed with hosting, end with one month's notice and end with hosting. Draft for the danish-law review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The danish-law review and the maintainer's decisions on #621: - small, clearly bounded feature requests are included in hosting; only a large wish (a whole new module or a new integration) gets a fixed-price quote; - Priority and Express are targets, not guarantees, with an away clause for holidays and illness; - a monthly add-on can be ended in the portal or by email from the next month (Forbrugeraftaleloven § 28 a). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#625's hosting paragraph now says which feature requests are included and that they are picked up in a monthly round, one at a time. The add-on section refers to it instead of repeating it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The maintainer's decision on the terms review (#621): Priority and Express are targets, not guarantees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
c4387c4 to
ae452f8
Compare
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The maintainer's decision on the terms review (#621): Priority and Express are targets, not guarantees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(portal): let clients order the standard add-ons The maintainer approved a standard set of add-ons (offerings.json addons): monthly feature-request priority tiers, visitor statistics and email sending, and one-time extras such as an extra language, a contact form or online payments. - The receipt lists the add-ons that fit the request's offering (monthly ones only with hosting); the client ticks them and the summary before the order button shows each line and the total. - The order stores them with their unit prices (portal_order_addons, migration v25); its prices include them, so funding, withdrawals and settlements work unchanged. At most one priority tier per order. - The launch discount takes off the proposal's own one-time price only. - Numina invoices and Stripe Checkout get one line per add-on: one-time ones with the first charge, monthly ones every month. - The confirmation email, the receipt and the operator's page list them. - business-site AGENTS.md: requests outside the offer become addon-candidate issues that describe only the request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(portal): keep an impossible add-on choice and retry orders as stored Codex review on #623: - An impossible add-on choice (both priority tiers, or units out of range) stays ticked with its reason, and the receipt offers no order until the client corrects it, instead of silently ordering without add-ons. - A retry of an existing order compares the add-ons it names with the order's stored ids and units, keeping their stored prices, so a later catalogue change does not turn a card restart into a conflict. Only a new order is checked against the current catalogue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(portal): describe the priority tiers as targets The maintainer's decision on the terms review (#621): Priority and Express are targets, not guarantees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(portal): add the add-on alert's Danish words to the spelling list Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(portal): bind add-on prices to what the client saw, and pass HTMLHint Codex review on #623: a catalogue price change deployed between the order summary and the order button would have charged the new price. Each add-on's form value now carries the unit price the client was shown, and a new order is refused unless the catalogue still has it. A retry keeps the stored prices. CI's template check (HTMLHint) refused template actions inside tags: the add-on checkboxes and the units select now render whole tags in if/else and use wrapping labels instead of template ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: drop spelling words main already lists Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(portal): follow the add-on heading with a line break MegaLinter's djlint (H015) wants a line break after a heading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: Apply megalinter fixes --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: botantler-1[bot] <185060876+botantler-1[bot]@users.noreply.github.com>
Merge reviewed main while retaining its portal privacy activation and shared FEATURE_ADDONS gate. Connect the gated terms to the listing and keep runtime packages off until their coordinated activation. Part of #21.
Repair and base reconciliation at
The original requirement to coordinate the add-on release remains binding. This stays draft; #632 tracks removing the temporary shared gate only after activation and live bilingual proof. Source merge and legal/release acceptance remain separate. |
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
The current-head workflow security audit failed operationally: job 133079981464 reports After rechecking the unchanged head This remains draft. A completed current-head security audit and current-head review are still required. The shared default-off add-on gate and coordinated activation/bilingual acceptance requirements remain binding. |
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Blocked by #21 The workflow-security retry 43800609879, attempt 2 completed successfully at The PR requires the terms and add-on offering to go live together. The applicable portal ordering and release evidence under #21 is still incomplete, so this stays draft with Re-entry: establish the applicable #21 prerequisites for the coordinated add-on release, then revalidate this head, checks, findings and ownership and exercise the English/Danish listing and matching terms before promotion. #632 remains the later flag-retirement work. |

Why
Customers need English and Danish terms that match the approved add-ons and explain the limits of faster feature-request handling.
What
Adds matching terms for Priority and Express targets, holidays and illness, one request at a time, and ending monthly add-ons in the portal or by email. The terms and public add-on listing stay switched off together until the coordinated release.
Part of #21