Skip to content

feat(legal): describe feature requests, priority tiers and fair use - #621

Draft
devantler wants to merge 5 commits into
mainfrom
claude/terms-feature-requests
Draft

devantler wants to merge 5 commits into
mainfrom
claude/terms-feature-requests

Conversation

@devantler

@devantler devantler commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Customers need English and Danish terms that match the approved add-ons and explain the limits of faster feature-request handling.

What

Adds matching terms for Priority and Express targets, holidays and illness, one request at a time, and ending monthly add-ons in the portal or by email. The terms and public add-on listing stay switched off together until the coordinated release.

Part of #21

⚠️ Merge order: keep this draft until portal ordering is enabled and the applicable release checks in #21 pass; publish the listing and terms together.

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danish-law review of the terms draft (taken over from the Danish-law session, which is blocked). This is not legal advice, and it does not say the terms are compliant. Read at daa6cc1.

Your three questions

  1. "About once a week" (Priority): make it concrete. For distance contracts with consumers, the trader must state beforehand when it undertakes to perform the service (forbrugeraftaleloven § 8, stk. 1). Unclear terms are read against the trader (aftaleloven § 38 b). Use the same shape as Standard: "requests are picked up in a weekly round" / "ønsker tages op i en ugentlig runde".
  2. Express: keep it a commitment, not a target. The customer pays for that speed. Calling it a "target" while the listing sells "within 1 business day" risks misleading marketing (markedsføringsloven §§ 5–6), and it makes the paid tier promise nothing. Two things to settle with the maintainer before go-live:
    • What happens on his own days off, such as holidays or illness? Options: say so in this paragraph (for example, "announced by email in advance, and Express is not charged for those days"), or accept the risk.
    • Whatever this paragraph says must match the public add-on listing word for word.
  3. Monthly add-on notice: one month to the end of a month is fine for private and business customers. It is at least as good for the customer as the five-month rule for fixed periods (forbrugeraftaleloven § 28), so no separate rule is needed. One thing to check: if hosting can be ended in the portal (#608, § 28 a), a monthly add-on ordered there should be ended the same way, alone or with hosting. The paragraph should then say "by email or in the portal", not only email.

Must change before this goes live

  • Clash with #625. #625 (the new prices) says hosting covers "hosting, monitoring, backups, security updates and minor fixes", and that "larger changes and new features get a fixed-price quote". This section says feature requests are included in a monthly round. Both can't be live at once. When the add-ons go live, update #625's hosting text everywhere it appears so it says the same as this section:
    • the terms' Hosting and ending it / Hosting og opsigelse paragraph;
    • hostingText and qualityScope in published-offer.ts;
    • hosting in offerings.json;
    • AGENTS.md.
  • Show fair use where the tiers are sold. The public listing must show the one-request-at-a-time limit next to Priority and Express, not only in the terms. A material limit hidden from the offer is misleading (markedsføringsloven § 6).

Minor

  • "There are no hourly rates." repeats the Prices section in #625. You can drop it here.
  • #625 also moves Last updated to 16 November 2026, the same line as here, so the two merge cleanly.

With the fixes above, I see no further blocker. Merge it together with the add-ons going live, as the description says.

🤖 Generated with Claude Code

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danish-law review (not legal advice). The section reads well in both languages. One conflict and three answers.

Conflict to fix before merge.

  • This section says feature requests are picked up monthly "at no extra cost" while a project is hosted, with only large wishes quoted.
  • The published copy in #625 says the opposite, in the hosting text, the quality scope and the terms' hosting paragraph: hosting covers "hosting, monitoring, backups, security updates and minor fixes; larger changes and new features get a fixed-price quote".
  • Marketing that contradicts the terms can mislead (Marketing Practices Act §5). When this merges, align those three texts with "feature requests are included in a monthly round; large wishes get a fixed-price quote", in EN and DA. Also update offerings.json hosting, which mirrors the hosting text.

Your open points.

  1. "about once a week" (Priority). For a paid tier, a vague promise is hard to document (§13), and it invites disputes about what was bought. Use a firm cadence the maintainer can keep, e.g. "once a week" / "en gang om ugen". If he can't commit to that, keep "about" but say what it means in practice.
  2. Express times as targets. Call them targets, and say what happens when they slip. A one-person business has illness and holidays, and a paid tier sold as a guarantee but delivered as a target is a misleading-claim risk. For example:
    • EN: "Express aims to start work on a request, and to reply, within 1 business day. If I am away, I tell you in advance and the times resume when I am back."
    • DA: "Med Ekspres er målet at begynde på et ønske og svare inden for 1 arbejdsdag. Er jeg væk, giver jeg besked på forhånd, og tiderne gælder igen, når jeg er tilbage."
  3. Monthly add-ons and the five-month rule. One month's notice to the end of a month, as drafted, is fine. It is more favourable than §28(1), and §28(5) only forbids a longer notice. It also matches the maintainer's "no minimum" hosting decision.
    • One addition: §28a. An add-on ordered in the portal must also be cancellable in the portal, not only by email. Use: "by email, or in the portal if you ordered it there" / "på e-mail eller i portalen, hvis du har bestilt det dér".

Minor (Danish). "Rimelig brug gælder på alle niveauer: én opgave er under arbejde pr. kunde ad gangen" is clear. Optionally use "der arbejdes på ét ønske ad gangen pr. kunde", so it uses the same word as "ønsker".

No objection to the remaining text. Merging together with the add-ons going live, as the body says, is right.

🤖 Generated with Claude Code

devantler added a commit that referenced this pull request Nov 16, 2026
The danish-law review and the maintainer's decisions on #621:
- small, clearly bounded feature requests are included in hosting; only
  a large wish (a whole new module or a new integration) gets a
  fixed-price quote;
- Priority and Express are targets, not guarantees, with an away clause
  for holidays and illness;
- a monthly add-on can be ended in the portal or by email from the next
  month (Forbrugeraftaleloven § 28 a).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler
devantler force-pushed the claude/terms-feature-requests branch from daa6cc1 to fd46807 Compare November 16, 2026 00:49
@devantler
devantler changed the base branch from main to claude/launch-prices-19 November 16, 2026 00:49
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Thanks for the review. I've applied it in fd46807, with the maintainer's decisions relayed by the coordinating session:

  1. Included vs quoted. Small, clearly bounded feature requests are included in hosting and picked up in a monthly round. Only a large wish, such as a whole new module or a new integration, gets a fixed-price quote. feat(offer): publish fixed prices, optional hosting and the launch offer #625's hosting text and terms still say every new feature is quoted. The launch-prices session is aligning them on feat(offer): publish fixed prices, optional hosting and the launch offer #625.
  2. Targets. Priority's target is to pick requests up about once a week. Express's targets are to start within 1 business day and reply within 1 business day. Both are called targets, not guarantees, with an away clause for holidays and illness.
  3. § 28 a. A monthly add-on can be ended in the portal or by email from the next month. The per-add-on cancellation in the portal is being built as its own PR.

The branch is rebased onto #625 (claude/launch-prices-19), which edits the same file.

devantler added a commit that referenced this pull request Nov 16, 2026
The maintainer's decision on the terms review (#621): Priority and
Express are targets, not guarantees.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for Review this PR's own commits; it is stacked on its base branch (rebased onto #625).

@devantler

Copy link
Copy Markdown
Contributor Author

Follow-up to my review above.

  • Express and Priority as targets with an away clause is the maintainer's decision, so it replaces my "keep it a commitment" point. Keep it honest: use the word "target" (EN) / "mål" (DA), with the same away clause, in the terms and in the public add-on listing alike, so the listing promises nothing the terms don't.
  • The hosting clash is fixed on feat(offer): publish fixed prices, optional hosting and the launch offer #625's side (head 6a7538f). The hosting text and the terms now say that small, clearly bounded feature requests are included, picked up in a monthly round, one at a time, and that a large wish gets a fixed-price quote. Your first paragraph can drop what that hosting paragraph already says.

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T06:25:44.711043Z 3bf143d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd468073e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/components/business/legal-copy.ts Resolved
Comment thread src/components/business/legal-copy.ts Resolved
devantler added a commit that referenced this pull request Nov 16, 2026
The danish-law review and the maintainer's decisions on #621:
- small, clearly bounded feature requests are included in hosting; only
  a large wish (a whole new module or a new integration) gets a
  fixed-price quote;
- Priority and Express are targets, not guarantees, with an away clause
  for holidays and illness;
- a monthly add-on can be ended in the portal or by email from the next
  month (Forbrugeraftaleloven § 28 a).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler
devantler force-pushed the claude/terms-feature-requests branch from fd46807 to c4387c4 Compare November 16, 2026 00:59
devantler added a commit that referenced this pull request Nov 16, 2026
The maintainer's decision on the terms review (#621): Priority and
Express are targets, not guarantees.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for Review this PR's own commits; it is stacked on its base branch, now on #625's latest head.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: c4387c4041

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Base automatically changed from claude/launch-prices-19 to main November 16, 2026 01:21
devantler and others added 3 commits November 16, 2026 02:22
The maintainer approved standard add-ons, including two monthly
feature-request priority tiers. The terms gain one section, EN and DA,
after "Hosting and ending it":
- hosted projects' feature requests are picked up in a monthly round at
  no extra cost; large wishes get a fixed-price quote; no hourly rates;
- Priority picks requests up about weekly; Express starts work and
  replies within 1 business day;
- fair use: one request in progress per customer at a time;
- other add-ons are part of the order; monthly ones are billed with
  hosting, end with one month's notice and end with hosting.

Draft for the danish-law review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The danish-law review and the maintainer's decisions on #621:
- small, clearly bounded feature requests are included in hosting; only
  a large wish (a whole new module or a new integration) gets a
  fixed-price quote;
- Priority and Express are targets, not guarantees, with an away clause
  for holidays and illness;
- a monthly add-on can be ended in the portal or by email from the next
  month (Forbrugeraftaleloven § 28 a).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#625's hosting paragraph now says which feature requests are included
and that they are picked up in a monthly round, one at a time. The
add-on section refers to it instead of repeating it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
devantler added a commit that referenced this pull request Nov 16, 2026
The maintainer's decision on the terms review (#621): Priority and
Express are targets, not guarantees.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler
devantler force-pushed the claude/terms-feature-requests branch from c4387c4 to ae452f8 Compare November 16, 2026 01:29
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for Re-review this PR's own commits after rebasing onto main (#625 merged); findings on earlier heads are answered on their threads.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: ae452f8768

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

devantler added a commit that referenced this pull request Nov 16, 2026
The maintainer's decision on the terms review (#621): Priority and
Express are targets, not guarantees.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
devantler added a commit that referenced this pull request Nov 16, 2026
* feat(portal): let clients order the standard add-ons

The maintainer approved a standard set of add-ons (offerings.json
addons): monthly feature-request priority tiers, visitor statistics and
email sending, and one-time extras such as an extra language, a contact
form or online payments.

- The receipt lists the add-ons that fit the request's offering
  (monthly ones only with hosting); the client ticks them and the
  summary before the order button shows each line and the total.
- The order stores them with their unit prices (portal_order_addons,
  migration v25); its prices include them, so funding, withdrawals and
  settlements work unchanged. At most one priority tier per order.
- The launch discount takes off the proposal's own one-time price only.
- Numina invoices and Stripe Checkout get one line per add-on: one-time
  ones with the first charge, monthly ones every month.
- The confirmation email, the receipt and the operator's page list them.
- business-site AGENTS.md: requests outside the offer become
  addon-candidate issues that describe only the request.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(portal): keep an impossible add-on choice and retry orders as stored

Codex review on #623:
- An impossible add-on choice (both priority tiers, or units out of
  range) stays ticked with its reason, and the receipt offers no order
  until the client corrects it, instead of silently ordering without
  add-ons.
- A retry of an existing order compares the add-ons it names with the
  order's stored ids and units, keeping their stored prices, so a later
  catalogue change does not turn a card restart into a conflict. Only a
  new order is checked against the current catalogue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(portal): describe the priority tiers as targets

The maintainer's decision on the terms review (#621): Priority and
Express are targets, not guarantees.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore(portal): add the add-on alert's Danish words to the spelling list

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(portal): bind add-on prices to what the client saw, and pass HTMLHint

Codex review on #623: a catalogue price change deployed between the
order summary and the order button would have charged the new price.
Each add-on's form value now carries the unit price the client was
shown, and a new order is refused unless the catalogue still has it. A
retry keeps the stored prices.

CI's template check (HTMLHint) refused template actions inside tags:
the add-on checkboxes and the units select now render whole tags in
if/else and use wrapping labels instead of template ids.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore: drop spelling words main already lists

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(portal): follow the add-on heading with a line break

MegaLinter's djlint (H015) wants a line break after a heading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore: Apply megalinter fixes

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: botantler-1[bot] <185060876+botantler-1[bot]@users.noreply.github.com>
Gate only the new bilingual add-on section with a private build setting. Pin runtime packages off, exercise both rendered states and inherited-setting refusal, and track retirement in #632. Part of #21.
Merge reviewed main while retaining its portal privacy activation and shared FEATURE_ADDONS gate. Connect the gated terms to the listing and keep runtime packages off until their coordinated activation. Part of #21.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Repair and base reconciliation at 3bf143db77cf6e97be529f0ab9e93092461fd033:

  • The new EN/DA terms use the same default-off FEATURE_ADDONS setting as the public add-on listing. Both runtime packages retain the reviewed off pin. The merged base's portal-privacy activation is preserved; no second add-on flag remains.
  • The existing hosting paragraphs include clearly bounded requests and reserve separate quotes for large requests. The added section refers to that rule. Both review threads are answered and resolved.
  • Local validation passed: all 111 web tests, Svelte checks with zero diagnostics, the full public build, actual rendered company configurations in all six states, invalid-setting and private-output controls, runtime presentation controls, ShellCheck and diff checks. A first build overlapped a journal race-test fixture; after separating those commands, the complete build and rendered-state matrix passed.
  • Merged reviewed main 4a6099cdf19502d2891fbd0e7d1d2228c4963df8 without rewriting history. The conflict is cleared and fresh CI 43800609856 is queued at this head. No new-head review requested before CI settles.

The original requirement to coordinate the add-on release remains binding. This stays draft; #632 tracks removing the temporary shared gate only after activation and live bilingual proof. Source merge and legal/release acceptance remain separate.

@github-actions

Copy link
Copy Markdown

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 1.8s
✅ CSS stylelint 1 0 0 0 2.9s
✅ GO golangci-lint yes yes no no 183.24s
✅ GO revive 191 0 0 1.35s
✅ HTML djlint 5 0 0 2.6s
✅ HTML htmlhint 5 0 0 0.56s
✅ JSON jsonlint 2 0 0 0.11s
✅ JSON prettier 2 0 0 0 1.5s
✅ JSON v8r 2 0 0 1.17s
✅ MARKDOWN markdownlint 17 0 0 0 2.34s
✅ MARKDOWN markdown-table-formatter 17 0 0 0 0.86s
✅ REPOSITORY betterleaks yes no no 1.11s
✅ REPOSITORY checkov yes no no 23.85s
✅ REPOSITORY git_diff yes no no 0.26s
✅ REPOSITORY grype yes no no 256.46s
✅ REPOSITORY osv-scanner yes no no 220.68s
✅ REPOSITORY secretlint yes no no 1.9s
✅ REPOSITORY syft yes no no 3.82s
✅ REPOSITORY trivy yes no no 14.39s
✅ REPOSITORY trivy-sbom yes no no 0.32s
✅ REPOSITORY trufflehog yes no no 5.16s
✅ SPELL cspell 218 0 0 8.74s
✅ SPELL lychee 24 0 0 191.46s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.2.0 --custom-flavor-setup --custom-flavor-linters COPYPASTE_JSCPD,CSS_STYLELINT,GO_GOLANGCI_LINT,GO_REVIVE,HTML_DJLINT,HTML_HTMLHINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_CSPELL,SPELL_LYCHEE

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

The current-head workflow security audit failed operationally: job 133079981464 reports fatal: no audit was performed because its impostor-commit audit received GitHub HTTP 503 while reading an upstream action's tags. This is an incomplete audit, with no security verdict.

After rechecking the unchanged head 3bf143db77cf6e97be529f0ab9e93092461fd033, current activity and local ownership, I requested one rerun of that failed job. Attempt 2 is in progress at the same source. No further retry is scheduled; the next invocation should collect its result once. A repeat failure needs diagnosis.

This remains draft. A completed current-head security audit and current-head review are still required. The shared default-off add-on gate and coordinated activation/bilingual acceptance requirements remain binding.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 3bf143db77

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Blocked by #21

The workflow-security retry 43800609879, attempt 2 completed successfully at 3bf143db77cf6e97be529f0ab9e93092461fd033. The current-head Codex review reported no major issues, and both diff threads are resolved. This clears the failed-audit and missing-review handoff; it does not establish legal approval or release acceptance.

The PR requires the terms and add-on offering to go live together. The applicable portal ordering and release evidence under #21 is still incomplete, so this stays draft with FEATURE_ADDONS off. The release hold is now recorded explicitly rather than requesting another review of this unchanged head.

Re-entry: establish the applicable #21 prerequisites for the coordinated add-on release, then revalidate this head, checks, findings and ownership and exercise the English/Danish listing and matching terms before promotion. #632 remains the later flag-retirement work.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant