Skip to content

fix(release): sign releases as KHoist without dropping pending publications - #626

Draft
devantler wants to merge 3 commits into
mainfrom
codex/tenant-own-release-625
Draft

devantler wants to merge 3 commits into
mainfrom
codex/tenant-own-release-625

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

KHoist releases depend on the platform approving changes to the shared publisher, which delays delivery.

What

KHoist now signs its own releases so the platform can follow them automatically. Publications retain their queue and share the previous publisher lock, so overlapping releases cannot skip a publication or move an alias backwards. This continues #625 in the required Codex branch namespace.

Fixes #618

Merge order: switch the platform documentation source after this publisher has produced a signed release.

devantler and others added 3 commits November 16, 2026 12:55
…ublish action

The publish job now checks out the tagged commit and runs the composite
devantler-tech/.github/actions/publish-app action (v21.7.2) directly in
cd.yaml, so the controller image and the manifests artifact are signed as
https://github.com/devantler-tech/khoist/.github/workflows/cd.yaml@refs/tags/vX.Y.Z
instead of as the shared reusable publisher (devantler-tech/monorepo ADR 0017).
Image and artifact names are unchanged: ghcr.io/devantler-tech/khoist and
ghcr.io/devantler-tech/khoist/manifests.

The smoke job verifies the image against that identity. The
publisher-identity command, which only derived the shared publisher's
pinned identity, is removed, and so is the Dependabot ignore that held the
publisher on a platform-approved revision.

Fixes #618

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The smoke job's cosign identity names cd.yaml on the release tag; it is
compared by Cosign, not fetched, like the other signing identities.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Continues #625 with both review findings fixed: the publisher retains pending releases and shares the previous publisher lock. Local validation passed: Go build, all 1,541 Go tests, release contract controls, actionlint with the existing shared CI compatibility arguments, and the workflow security scan. The added queue guard failed before the configuration fix and passed afterwards. The first own-signed release remains a post-merge verification gate.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2d75402c-7e2a-415a-bb99-a2f496b36a6f
Commits

Reviewing files that changed from the base of the PR and between db4ee4b and 01a8f03.

Files selected for processing: 7

  • .github/dependabot.yaml
  • .github/workflows/cd.yaml
  • README.md
  • lychee.toml
  • scripts/publisher-identity/main.go
  • scripts/publisher-identity/main_test.go
  • scripts/release.test.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

✅⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ ACTION actionlint 8 0 0 0.25s
✅ ACTION zizmor 8 0 0 0 1.69s
✅ BASH bash-exec 68 0 0 0.46s
✅ BASH shellcheck 68 0 0 11.31s
✅ BASH shfmt 68 0 0 0 0.25s
✅ COPYPASTE jscpd yes no no 1.75s
✅ CSS stylelint 4 0 0 0 1.11s
✅ DOCKERFILE hadolint 4 0 0 0.08s
✅ EDITORCONFIG editorconfig-checker 567 0 0 0.45s
✅ HTML djlint 3 0 0 1.41s
✅ HTML htmlhint 3 0 0 0.21s
✅ JSON jsonlint 22 0 0 0.1s
✅ JSON prettier 18 0 0 0 1.03s
✅ JSON v8r 22 0 0 8.05s
⚠️ MARKDOWN markdownlint 79 0 11 0 1.95s
✅ MARKDOWN markdown-table-formatter 79 0 0 0 0.29s
✅ REPOSITORY betterleaks yes no no 1.59s
✅ REPOSITORY checkov yes no no 24.4s
✅ REPOSITORY git_diff yes no no 0.11s
✅ REPOSITORY grype yes no no 83.37s
✅ REPOSITORY osv-scanner yes no no 10.11s
✅ REPOSITORY secretlint yes no no 1.58s
✅ REPOSITORY syft yes no no 6.26s
✅ REPOSITORY trivy yes no no 16.53s
✅ REPOSITORY trivy-sbom yes no no 13.01s
✅ REPOSITORY trufflehog yes no no 6.52s
✅ SPELL lychee 185 0 0 7.56s
✅ XML xmllint 2 0 0 0 0.1s
✅ YAML prettier 63 0 0 0 1.31s
✅ YAML v8r 78 0 0 11.71s
✅ YAML yamllint 67 0 0 1.66s

Detailed Issues

⚠️ MARKDOWN / markdownlint - 11 errors
AGENTS.md:79:401 error MD013/line-length Line length [Expected: 400; Actual: 593]
docs/adr/0025-retained-identifiers-after-the-rename.md:24:401 error MD013/line-length Line length [Expected: 400; Actual: 402]
docs/adr/0025-retained-identifiers-after-the-rename.md:26:401 error MD013/line-length Line length [Expected: 400; Actual: 402]
docs/adr/0025-retained-identifiers-after-the-rename.md:27:401 error MD013/line-length Line length [Expected: 400; Actual: 402]
docs/adr/0025-retained-identifiers-after-the-rename.md:28:401 error MD013/line-length Line length [Expected: 400; Actual: 402]
docs/adr/0025-retained-identifiers-after-the-rename.md:29:401 error MD013/line-length Line length [Expected: 400; Actual: 402]
docs/adr/0025-retained-identifiers-after-the-rename.md:31:401 error MD013/line-length Line length [Expected: 400; Actual: 402]
docs/adr/0025-retained-identifiers-after-the-rename.md:32:401 error MD013/line-length Line length [Expected: 400; Actual: 402]
docs/adr/0025-retained-identifiers-after-the-rename.md:33:401 error MD013/line-length Line length [Expected: 400; Actual: 402]
docs/adr/0025-retained-identifiers-after-the-rename.md:34:401 error MD013/line-length Line length [Expected: 400; Actual: 402]
docs/adr/0025-retained-identifiers-after-the-rename.md:35:401 error MD013/line-length Line length [Expected: 400; Actual: 402]

See detailed reports in MegaLinter artifacts

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: Go

Go / code-coverage/go

main codex/tenant-own-rel... 01a8f03 +/-
— 69% —

Line coverage data for the main branch is not yet available.

View coverage of the 10 most covered files.
File main codex/tenant-own-rel... 01a8f03 +/-
internal/catalog/catalog.go — 98% —
internal/contro...t_controller.go — 94% —
internal/provider/v1/arango.go — 93% —
internal/preflight/check.go — 93% —
internal/provid...r/v1/percona.go — 92% —
internal/registry/lineage.go — 91% —
internal/contro.../composition.go — 90% —
internal/preflight/input.go — 88% —
examples/api-consumer/main.go — 80% —
internal/registry/discovery.go — 79% —

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T13:47:09.545280Z 01a8f03 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 01a8f03c1b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Blocked by devantler-tech/platform#6433

The complete own-release change is being extended with the matching chart and release-verifier work tracked in #627. That signed local preparation passes the full repository validation, but has not been pushed. The published head remains unchanged. Keep this draft unqueued while the critical fixed-SDK publication and current-main recovery get their runner evidence; the next source update will require fresh exact-head CI and review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(release): sign releases as this repository with the shared publish action

1 participant