Repository navigation
feat(business-site): give the portal the site's SES sender for its emails - #6368
Conversation
…ails The portal must send order confirmations and withdrawal receipts by email itself (Consumer Contracts Act, sections 13 and 20 a; business-site#21), using the site's existing send-only SES sender (#5400, #6311): From no-reply@devantler.tech only. - business-site-runtime carries smtp-username and smtp-password from OpenBao apps/business-site/smtp, read through the ClusterSecretStore the way ZITADEL's zitadel-smtp reads it. - The portal egress policy allows email-smtp.eu-central-1.amazonaws.com on 587/TCP (STARTTLS). Nothing reads the new items until a business-site release projects them, and the portal sends nothing while its flags are off. This must deploy before that release, because a projected key that is missing keeps new pods from starting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codex review for business-site-runtime gains smtp-username/smtp-password from OpenBao apps/business-site/smtp via the ClusterSecretStore, and the portal egress policy gains SES SMTP 587; check nothing widens beyond that and the rollout-order note |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
✅
|
✅
|
The platform now adds the site's send-only SES credential to business-site-runtime as smtp-username and smtp-password (devantler-tech/platform#6368, deployed and synced). Project both items so the portal settings can name them; nothing reads them until then. Document the two settings lines. Part of #21 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

What
The Danish-law review found that the portal itself must send order confirmations and withdrawal receipts by email (Consumer Contracts Act, sections 13 and 20 a; devantler-tech/business-site#21). It uses the site's existing send-only SES sender from #5400 and #6311, as agreed with the session that owns
business-site-runtime: no new sender.external-secret-runtime.yaml:business-site-runtimenow also carriessmtp-usernameandsmtp-passwordfrom OpenBaoapps/business-site/smtp. They are read through theopenbaoClusterSecretStore, the same way ZITADEL'szitadel-smtpreads that entry. Therestrict-tenant-secret-storescarve-out for this platform-applied ExternalSecret already allows it. The credential may send only asno-reply@devantler.tech.cilium-network-policy-portal-egress.yaml: the portal egress policy allowsemail-smtp.eu-central-1.amazonaws.comon 587/TCP (STARTTLS), next to the existing database,login.devantler.techand DNS rules. The policy also selects the migration Job, which mounts no SMTP credential.Order of rollout
Nothing reads the new items until a business-site release mounts them, and the portal sends nothing while its flags are off.
This PR must deploy before that release: a mounted key that is missing from the Secret keeps every new pod from starting, including the public pages. The business-site change that mounts and uses these items follows separately.
SES is still in sandbox, so until AWS grants production access it only delivers to verified addresses.
Validation
approved-surface.txtis unchanged.🤖 Generated with Claude Code