Test CI quality checks workflow with TypeScript file changes#33
Closed
pjurczynski wants to merge 6 commits into
Closed
Test CI quality checks workflow with TypeScript file changes#33pjurczynski wants to merge 6 commits into
pjurczynski wants to merge 6 commits into
Conversation
The quality script already includes linting along with other comprehensive code quality checks (complexity, duplication, code smells, etc.), so the separate lint step is redundant. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
GitHub Actions uses shallow clones by default (fetch-depth: 1) which only fetches the latest commit. Our quality check script uses `git diff --name-only HEAD~1 HEAD` to identify changed files in push events, but HEAD~1 doesn't exist in a shallow clone with only one commit. Setting fetch-depth: 2 ensures that both HEAD and HEAD~1 are available, allowing the script to compare the current commit with its parent to determine which TypeScript files have changed and need quality checking. This prevents the "fatal: bad object [SHA]" error that occurs when the script tries to reference HEAD~1 in a shallow clone environment. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file intentionally contains quality issues to test that the CI workflow correctly runs quality checks on changed TypeScript files: - Method with too many parameters (5 parameters) - High cyclomatic complexity with nested conditions - Comments that may trigger comment-related quality checks - Potential feature envy pattern This will help verify that: 1. The CI workflow correctly identifies changed .ts files 2. Quality checks run only on changed files 3. The fetch-depth: 2 setting allows git diff to work properly 4. Quality issues are properly reported in the CI output 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Expected Behavior
The CI workflow should:
src/test-ci-quality.tshas changed🤖 Generated with Claude Code