Repository navigation
feat: add reviewed bulk cleanup operations #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Bulk cleanup | ||
|
|
||
| ## Purpose | ||
|
|
||
| Provide reviewed bulk transformations for catalogue values while preserving scope visibility and a | ||
| single undo step for each accepted operation. | ||
|
|
||
| ## Scope | ||
|
|
||
| 1. Preview selected rows and columns before and after an operation. | ||
| 2. Support whitespace cleanup, Unicode normalization, case normalization, delimiter splitting or | ||
| joining, regex replacement, and duplicate detection/removal. | ||
| - Use NFC for canonical Unicode normalization. | ||
| - Offer NFKC as a separate compatibility-normalization operation because it can change meaning. | ||
| - Use Unicode default casing for lower-, upper-, and title-case operations. Do not use the host | ||
| locale. | ||
| 3. Report skipped and failed cells without silently changing them. | ||
| 4. Apply an accepted transformation as one complete undoable batch. | ||
|
|
||
| ## Non-goals | ||
|
|
||
| - Unreviewed automatic cleanup. | ||
| - Spreadsheet formulas or presentation formatting. | ||
| - Replacing the current find-and-replace flow where it remains the simpler operation. | ||
|
|
||
| ## Dependencies and merge notes | ||
|
|
||
| Do not implement the preview/confirmation UI until PR #118 has landed. That PR changes the table | ||
| panel and delegate surfaces this work would otherwise conflict with. The transformation semantics | ||
| and fixtures may be designed before then. | ||
|
|
||
| ## Definition of done | ||
|
|
||
| - Every operation shows the affected-cell preview and scope before it writes. | ||
| - Cancel makes no changes; apply is one undo step. | ||
| - Tests cover filtered rows, selection scope, no-op values, and failures. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.