Skip to content

change non-convergence flag==>2 - #81

Merged
dgilford merged 3 commits into
masterfrom
numerical_instability
Oct 7, 2025
Merged

dgilford merged 3 commits into
masterfrom
numerical_instability

Conversation

@dgilford

@dgilford dgilford commented Oct 7, 2025

Copy link
Copy Markdown
Owner

This update changes the way the flags are defined, modifying pi.py so that the code consistently outputs IFL=2 when the algorithm fails to converge. This addresses part of #80 by being explicit about non-convergence when the algorithm fails.

@dgilford dgilford closed this Oct 7, 2025
@dgilford dgilford reopened this Oct 7, 2025
@dgilford dgilford closed this Oct 7, 2025
@dgilford dgilford reopened this Oct 7, 2025

@maresb maresb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgilford, I fixed this for you. I had to update the dependencies due to breakage in a MacOS upgrade.

@dgilford
dgilford merged commit da0cb08 into master Oct 7, 2025
5 checks passed
@dgilford
dgilford deleted the numerical_instability branch October 7, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants