Skip to content

change non-convergence flag==>2 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgilford merged 3 commits into from
Oct 7, 2025
Merged

change non-convergence flag==>2 #81

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5bd314
change non-convergence flag==>2
dgilford Oct 7, 2025
b142d45
fixed print error
dgilford Oct 7, 2025
564516f
Merge branch 'master' into numerical_instability
maresb Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/tcpyPI/pi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
Revised 10/15/2020 by D. Gilford to add missing SST-->IFL=0 condition/check
Revised 2/1/2021 by D. Gilford to validate units of input SSTs/T profile (should be Celsius)
Modernized 2/20/2025 by B. Mares and D. Gilford
Revised 10/7/2025 by D. Gilford updating non-convergence flag==>2
"""
# doctest: +ELLIPSIS

Expand Down Expand Up @@ -657,16 +658,16 @@ def pi(SSTC,MSL,P,TC,R,CKCD=0.9,ascent_flag=0,diss_flag=1,V_reduc=0.8,ptop=50,mi
PMOLD=PM
# store the current step's pressure
PM=PNEW

# increase iteration count in the loop
NP += 1

#
# *** If the routine does not converge, set IFL=0 and return missing PI ***
# *** If the routine does not converge, set IFL=2 and return missing PI ***
#
if (NP > 200) or (PM < 400):
VMAX=np.nan
PMIN=np.nan
IFL=0
IFL=2
TO=np.nan
OTL=np.nan
return(VMAX,PMIN,IFL,TO,OTL)
Expand Down