Repository navigation
build(dioxus): take the patched winit-appkit from the Blitz fork - #3
Merged
Merged
Conversation
…nit-appkit dioxus-native moves to 0.8.0-alpha.3, whose keyboard-types names keys Key::Named(NamedKey::…) and ⌘ META. The editor turns the window's input method on while a value is open, draws a composition underlined after the buffer, and tells the input method the text before the caret, so dead keys and composing input methods type into a value. The app takes winit-appkit from leaf's main by git, so press-and-hold accents and the emoji picker work on macOS too. The menu tests that build muda items are ignored on macOS: muda makes them on the main thread only, and libtest runs tests off it. They failed there before this change. Behavioural-change: flower-dioxus's Editor enables and disables the window's input method itself, and handles Ime::Preedit and Ime::DeleteSurrounding as well as Ime::Commit.
The org keeps its patched Blitz stack, winit included, in diaryx-org's Blitz fork (patches/ there), where leaf's patches/winit-appkit moved. Same crate and patch; only where it comes from changes.
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The org now keeps its patched Blitz stack, winit included, in diaryx-org/blitz (`patches/` there). leaf's `patches/winit-appkit` moves there (diaryx-org/blitz#2). This PR repoints `apps/flower-dioxus`'s `[patch.crates-io] winit-appkit` from leaf's `main` to the fork's `leaf` branch, and updates the two docs that named leaf. The crate and the patch are the same.
Merge after diaryx-org/blitz#1 and #2 are merged into `leaf`. Then run `cargo update -p winit-appkit --manifest-path apps/flower-dioxus/Cargo.toml` here; I'll add that lockfile commit. Until then the branch's lockfile still points at leaf.
Verified: `cargo check` of `apps/flower-dioxus` against the fork's copy, through a local override.