Repository navigation
Ad landing page: new address, side-by-side buttons, country code dropdown - #48
Merged
Merged
Conversation
The ad landing page reads the campaign and click ids from the address, and the Meta and Google Analytics cookies only for the purposes the visitor allowed. They are sealed into the sign-up token with the visitor's details, so the platform can keep which ad an account came from (plan 59).
/start is noindex in the meta tag and the X-Robots-Tag header, but no longer nofollow once the site is live. The per-route nofollow option added for it is removed, since nothing else uses it. Tests now cover the live behaviour: "noindex, follow" in the meta tag and "noindex" in the header.
The page lives at /website-landing-page (rupee and dollar copies). The old /start address redirects there with its query string, so utm and click tags survive. The noindex header, the registry entry and the tests follow the new path; the page stays out of the sitemap.
…de dropdown The two form buttons sit side by side with equal size: "Pay now" in ink and "Talk to us" in a light copper fill, each with a round icon chip at the right edge (arrow, WhatsApp) and the label centred beside it. They stack only on the narrowest screens. The price card's pay button matches, through an optional centred label on the shared arrow button. The mobile field has a custom country code dropdown in the site's style (34 countries, India first and the default on the rupee page, the browser's country on the dollar page). It works with the keyboard, type-ahead and screen readers. The form sends the dial code and number together; India still takes a 10-digit Indian mobile, other countries any plausible international number, and a number typed with its own +code wins over the dropdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this releases
Updates to the ad landing page (four commits, five changes):
/startto/website-landing-page(rupee and dollar copies)./startredirects there and keeps the ad'sutm_and click tags, so any early link still works. Stillnoindex, still out of the sitemap.noindexonly: the meta tag becomesnoindex, followonce the site is live and the header isX-Robots-Tag: noindex. It no longer saysnofollow.robots.txtstays open so ad reviewers can load it.+codewins.f6b9434, from the other session): the ad a visitor came from travels, sealed, in the sign-up link (plan 59).Before or with this
digibranders/brandbasket-platform#86, which is still open. Releasing the website first is safe: the live app ignores the extra data. Attribution just will not be recorded on accounts until #86 is merged.lib/start-token.tsmust stay identical in both repos./start.PLATFORM_LEADS_URLandLEADS_API_TOKEN(the same values as the platform's) for the form to store leads and prefill the sign-up.Checked
npm run lint,npm run typecheck,npm test(501),npm run buildandnpm run verify:htmlall pass. Tested on a local server: both buttons at 360px and 375px, the dropdown with mouse and keyboard, the/startredirect with its query string, the robots header, and the form request contents. Playwright e2e was not run locally; CI should cover it.