Runtime scene package loading for G1 MuJoCo#2594
Draft
Nabla7 wants to merge 8 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #2594 +/- ##
==========================================
+ Coverage 69.61% 70.80% +1.19%
==========================================
Files 878 902 +24
Lines 79326 81283 +1957
Branches 7126 7442 +316
==========================================
+ Hits 55220 57553 +2333
+ Misses 22301 21836 -465
- Partials 1805 1894 +89
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 75 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes N/A
Runtime stacks need a stable way to consume cooked scene packages without depending on the offline cooking toolchain. The contract also needs to make browser assets explicit by backend, because Rerun and Babylon do not support exactly the same GLB extension set.
Solution
ScenePackagecontract and scene resolver for--scene none,--scene office, metadata paths, package directories, and composed.mjbpaths.ScenePackage.browser_visual_path(target), with legacy fallback for currently shipped packages.rerunvisual asset instead of assuming every browser GLB is Rerun-compatible..mjbloading for large scenes where XML compile time dominates./cmd_velwiring, raycast lidar/nav/Rerun visualization, animated URDF robot visualization, and ONNX provider cleanup../bin/lfs_pushworkflow.How to Test
G1 with the cooked office scene:
G1 without a scene:
Prefer
headless=truefor normal testing and inspect Rerun native.headless=falseopens the MuJoCo window and can run much slower.Checks run locally:
Earlier branch validation also covered focused runtime/nav/Rerun
ruff,py_compile,dimos/codebase_checks/test_no_all.py, anddimos/visualization/rerun/test_scene_package.py.Contributor License Agreement