Fix proxy extranonce range overflow after adding additional_coinbase_data#146
Open
Priceless-P wants to merge 1 commit into
Open
Fix proxy extranonce range overflow after adding additional_coinbase_data#146Priceless-P wants to merge 1 commit into
additional_coinbase_data#146Priceless-P wants to merge 1 commit into
Conversation
Fi3
reviewed
Oct 30, 2025
| let range_1 = prefix_len..prefix_len + tproxy_e1_len; // downstream extranonce1 | ||
| let range_2 = prefix_len + tproxy_e1_len | ||
| ..prefix_len + m.extranonce_size as usize; // extranonce2 | ||
| let range_1 = prefix_len..tproxy_e1_len; // downstream extranonce1 |
Contributor
There was a problem hiding this comment.
since you are at it remove the proxy_extranonce1_len function that looks reduntant
Collaborator
Author
There was a problem hiding this comment.
proxy_extranonce1_len is still used elsewhere
https://github.com/demand-open-source/demand-cli/blob/master/src/translator/upstream/upstream.rs#L533
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this change ,
m.extranonce_sizegrew from 16 to 32 bytes. Proxy currently double-counted the prefix when calculating extranonce ranges, this now causes invalidExtranonceRange on channel creation.This PR corrects the math by treating
tproxy_e1_lenas the actual end ofrange_1.Currently we added the prefix twice:
With this change, we use
tproxy_e1_lendirectly:Also changed
extranonce2_lenin bridge.rs:let extranonce2_len = m.extranonce_size - prefix_lenNow it works but I’m not sure if it is working the way we want .
Fixes https://github.com/demand-open-source/demand-pool/issues/264
Looking forward to your review @Fi3 @jbesraa