Skip to content

Fix proxy extranonce range overflow after adding additional_coinbase_data #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Priceless-P wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix proxy extranonce range overflow after adding additional_coinbase_data #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/translator/proxy/bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ impl Bridge {
if let Some(Mining::OpenExtendedMiningChannelSuccess(success)) = message.next() {
info!("New extended channel opened with id {}", success.channel_id);
let extranonce = success.extranonce_prefix.to_vec();
let extranonce2_len = success.extranonce_size;
let extranonce2_len =
success.extranonce_size - success.extranonce_prefix.len() as u16;
self.target
.safe_lock(|t| *t = success.target.to_vec())
.map_err(|e| {
Expand Down
5 changes: 2 additions & 3 deletions src/translator/upstream/upstream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,8 @@ impl Upstream {
miner_extranonce2_size,
);
let range_0 = 0..prefix_len; // upstream extranonce1
let range_1 = prefix_len..prefix_len + tproxy_e1_len; // downstream extranonce1
let range_2 = prefix_len + tproxy_e1_len
..prefix_len + m.extranonce_size as usize; // extranonce2
let range_1 = prefix_len..tproxy_e1_len; // downstream extranonce1
Copy link
Copy Markdown
Contributor

@Fi3 Fi3 Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you are at it remove the proxy_extranonce1_len function that looks reduntant

Copy link
Copy Markdown
Collaborator Author

@Priceless-P Priceless-P Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proxy_extranonce1_len is still used elsewhere
https://github.com/demand-open-source/demand-cli/blob/master/src/translator/upstream/upstream.rs#L533

let range_2 = tproxy_e1_len..m.extranonce_size as usize; // extranonce2
let extended = match ExtendedExtranonce::from_upstream_extranonce(
extranonce_prefix.clone(), range_0.clone(), range_1.clone(), range_2.clone(),
).ok_or( Error::InvalidExtranonce(format!("Impossible to create a valid extended extranonce from {:?} {:?} {:?} {:?}",
Expand Down