Add option for comma separated lists - #30
Open
bon wants to merge 1 commit into
Open
Conversation
Useful, for example, for --extensions md,org,txt
dnaeon
reviewed
Jul 4, 2025
Owner
|
Hey @bon , Thanks for the PR! I've added a comment to the PR, let me know what you think, thanks again! |
dnaeon
reviewed
Jul 5, 2025
| (apply #'make-instance 'option-csv rest)) | ||
|
|
||
| (defmethod finalize-option ((o option-csv) &key) | ||
| (setf (option-value o) (cl-ppcre:split "," (option-value o)))) |
Owner
There was a problem hiding this comment.
The cl-ppcre system is not a direct or indirect dependency for clingon and this won't work.
Since clingon already depends on split-sequence we should probably use that instead.
Owner
|
One more thing -- could you please also add tests for the new option? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful, for example, for --extensions md,org,txt