Skip to content

Add option for comma separated lists #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option for comma separated lists #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/options.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,16 @@
(write-string (call-next-method) s)
(format s ":_files")))

(defclass option-csv (option-string)
()
(:documentation "An option which represents a comma-separated list"))

(defmethod make-option ((kind (eql :csv)) &rest rest)
(apply #'make-instance 'option-csv rest))

(defmethod finalize-option ((o option-csv) &key)
(setf (option-value o) (cl-ppcre:split "," (option-value o))))

@dnaeon dnaeon Jul 5, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cl-ppcre system is not a direct or indirect dependency for clingon and this won't work.

Since clingon already depends on split-sequence we should probably use that instead.

@bon bon Jul 6, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense.


Comment thread
dnaeon marked this conversation as resolved.
;;;;
;;;; Boolean options
;;;;
Expand Down