Remove Dev Proxy CA certificate when uninstalling for Win

[bartizan]

#847

[waldekmastykarz]

Cool! We'll check it out asap. Thank you!

[waldekmastykarz]

Couple of things that I noticed. I'll try to run it asap to see it in action. I like the idea!

[Copilot]

Pull Request Overview

This PR adds an automatic step to remove the Dev Proxy CA certificate when uninstalling on Windows and exposes the same functionality via the CLI.

• Introduces a DevProxyExecutable macro and an [UninstallRun] entry in both install.iss and install-beta.iss to invoke devproxy.exe cert remove during uninstall.
• Registers a new remove subcommand in the CLI (CreateCertRemoveCommand) and implements its handler (CertRemoveCommandHandler.RemoveCert).

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
install.iss	Defines DevProxyExecutable and adds [UninstallRun] to remove the cert on uninstall
install-beta.iss	Same changes as install.iss, targeting the beta executable
dev-proxy/ProxyHost.cs	Adds CreateCertRemoveCommand to the list of certificate commands
dev-proxy/CommandHandlers/CertRemoveCommandHandler.cs	Implements the logic to remove the trusted root certificate

Comments suppressed due to low confidence (3)

install.iss:50

• [nitpick] The RunOnceId "RemoveCert" is quite generic and may collide with other actions; consider namespacing it (e.g. "MyApp_RemoveCert") to avoid potential conflicts.

Filename: "{app}\{#DevProxyExecutable}"; Parameters: "cert remove"; RunOnceId: "RemoveCert"; Flags: runhidden;

dev-proxy/CommandHandlers/CertRemoveCommandHandler.cs:9

• The new RemoveCert handler isn’t covered by any unit tests. Consider adding tests to assert successful removal and proper error logging in failure scenarios.

public static void RemoveCert(ILogger logger)

dev-proxy/CommandHandlers/CertRemoveCommandHandler.cs:5

• This file references ILogger but doesn’t include the corresponding using directive. Add using Microsoft.Extensions.Logging; (or the appropriate namespace) at the top to resolve the type.

namespace DevProxy.CommandHandlers;

[waldekmastykarz]

Works nicely! Let's do a few small fixes before we merge it.

[waldekmastykarz]

Very nice and clean implementation for the prompt. Let's add the --force switch to the installer invocation so that it executes silently and we'll get it in

[bartizan]

@waldekmastykarz
I come to think how a prompt confirmation Y/n should be completed. It could be either by pressing Enter key or just single key (like 'y'or 'n'). It appears this PR implements key + Enter but trust-cert.sh we run to install a certificate uses single key.
In favor of consistency both have to be the same (I see one more fix comming). But which approach to choose?

The single key is faster, but Key+Enter method sort of safer, gives a better user control and seems to provide adherence to common CLI conventions. So I'd stick with key+enter. What do you think?

PS I am working on MacOS related part of the issue.

[waldekmastykarz]

Good point, thank you for bringing it up. Let's do y/n followed by ENTER. I'll create a separate issue for this.

[waldekmastykarz]

Hey @bartizan, is this PR ready for review or is there anything else that we need to do?

[bartizan]

Hey @bartizan, is this PR ready for review or is there anything else that we need to do?

it is ready for review.
Now it should complete the whole issue for Win and Mac.

[waldekmastykarz]

Nicely done and I like the refactoring of the HasRunFlag to a class with additional functionality. Let's iron out a few wrinkles and we'll get it in. 👏

[waldekmastykarz]

Marking as draft. Please mark as "Ready for review" when you've done the changes @bartizan. Thanks!

[waldekmastykarz]

Awesome!