fix(dracut-install): resolve dependencies even if not executable - #2196
Merged
Conversation
Library files on Debian/Ubuntu are not marked as executable. This causes `dracut-install` to not resolve dependencies: ``` $ ls -l /usr/lib/x86_64-linux-gnu/libarchive.so.13.7.7 -rw-r--r-- 1 root root 874648 Jun 25 2025 /usr/lib/x86_64-linux-gnu/libarchive.so.13.7.7 $ rm -rf foo && mkdir foo $ ./dracut-install -D foo -l /usr/lib/x86_64-linux-gnu/libarchive.so.13 $ find foo foo foo/usr foo/usr/lib foo/usr/lib/x86_64-linux-gnu foo/usr/lib/x86_64-linux-gnu/libarchive.so.13.7.7 foo/usr/lib/x86_64-linux-gnu/libarchive.so.13 ``` There is no requirement for library files to be executable. So resolve dependencies all files. `resolve_deps()` will check if the file is either an ELF file or a script. This will also resolve dependencies of scripts that are not marked executable, which might be an undesired side effect. In this case users are advised to either call `dracut-install` without `-l` or not include those files at all. Fixes: dracut-ng#2193
3 tasks
chewi
approved these changes
Feb 6, 2026
LaszloGombos
approved these changes
Feb 6, 2026
Conan-Kudo
enabled auto-merge (rebase)
February 6, 2026 14:25
Conan-Kudo
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library files on Debian/Ubuntu are not marked as executable. This causes
dracut-installto not resolve dependencies:There is no requirement for library files to be executable. So resolve dependencies all files.
resolve_deps()will check if the file is either an ELF file or a script.This will also resolve dependencies of scripts that are not marked executable, which might be an undesired side effect. In this case users are advised to either call
dracut-installwithout-lor not include those files at all.Fixes: #2193
Checklist