Skip to content

fix(dfctl): pass enable_task_id_based_blob_digest flag in preheat gRPC request - #2019

Merged
gaius-qi merged 1 commit into
mainfrom
feature/enable-task
Aug 27, 2026
Merged

fix(dfctl): pass enable_task_id_based_blob_digest flag in preheat gRPC request#2019
gaius-qi merged 1 commit into
mainfrom
feature/enable-task

Conversation

@gaius-qi

Copy link
Copy Markdown
Member

Description

The flag was never sent to the scheduler, making the CLI option a no-op. Also update the help text to clarify the flag applies to both scheduler gRPC mode and request SDK mode, and bump dragonfly-api to 2.3.6.

Related Issue

Motivation and Context

Screenshots (if appropriate)

…C request

The flag was never sent to the scheduler, making the CLI option a no-op.
Also update the help text to clarify the flag applies to both scheduler
gRPC mode and request SDK mode, and bump dragonfly-api to 2.3.6.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.6.0 milestone Aug 27, 2026
@gaius-qi gaius-qi self-assigned this Aug 27, 2026
@gaius-qi
gaius-qi requested review from a team as code owners August 27, 2026 15:41
@gaius-qi gaius-qi added the enhancement New feature or request label Aug 27, 2026
@gaius-qi
gaius-qi enabled auto-merge (squash) August 27, 2026 15:42
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.37%. Comparing base (96204e5) to head (8c72204).

Files with missing lines Patch % Lines
dragonfly-client/src/bin/dfctl/task.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2019      +/-   ##
==========================================
- Coverage   54.39%   54.37%   -0.03%     
==========================================
  Files         101      101              
  Lines       27400    27401       +1     
==========================================
- Hits        14904    14899       -5     
- Misses      12496    12502       +6     
Files with missing lines Coverage Δ
dragonfly-client/src/bin/dfctl/task.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi
gaius-qi merged commit 4a13ba5 into main Aug 27, 2026
9 checks passed
@gaius-qi
gaius-qi deleted the feature/enable-task branch August 27, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants