Skip to content

fix(dfctl): pass enable_task_id_based_blob_digest flag in preheat gRPC request #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaius-qi merged 1 commit into from
Aug 27, 2026
+8 −7
Merged

fix(dfctl): pass enable_task_id_based_blob_digest flag in preheat gRPC request #2019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ chrono = { version = "0.4.45", features = ["clock", "serde"] }
clap = { version = "4.6.1", features = ["derive", "env"] }
crc32fast = "1.5.0"
dashmap = "6.1.0"
dragonfly-api = "=2.3.5"
dragonfly-api = "=2.3.6"
dragonfly-client = { path = "dragonfly-client", version = "1.5.3" }
dragonfly-client-backend = { path = "dragonfly-client-backend", version = "1.5.3" }
dragonfly-client-config = { path = "dragonfly-client-config", version = "1.5.3" }
Expand Down
9 changes: 5 additions & 4 deletions dragonfly-client/src/bin/dfctl/task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,11 +512,11 @@ pub struct PreheatCommand {
long,
default_value_t = true,
env = "DFCTL_TASK_PREHEAT_ENABLE_TASK_ID_BASED_BLOB_DIGEST",
help = "Specify whether to generate task id based blob digest. It indicates whether to use the blob digest for task ID calculation \
help = "Specify whether to generate task id based blob digest, used in both scheduler gRPC mode and request SDK mode \
(scheduler gRPC mode applies it to image preheat only). It indicates whether to use the blob digest for task ID calculation \
when downloading from OCI registries. When enabled for OCI blob URLs (e.g., /v2/<name>/blobs/sha256:<digest>), \
the task ID is derived from the blob digest rather than the full URL. This enables deduplication across \
registries - the same blob from different registries shares one task ID, eliminating redundant downloads \
and storage"
the task ID is derived from the blob digest rather than the full URL, so the same blob from different registries \
shares one task ID. This enables deduplication across registries and eliminates redundant downloads and storage"
)]
enable_task_id_based_blob_digest: bool,

Expand Down Expand Up @@ -893,6 +893,7 @@ impl PreheatCommand {
timeout: Some(
prost_wkt_types::Duration::try_from(self.timeout).or_err(ErrorType::ParseError)?,
),
enable_task_id_based_blob_digest: self.enable_task_id_based_blob_digest,

// TODO: Support certificate chain.
certificate_chain: Vec::new(),
Expand Down
Loading