Skip to content

fix(ci): pass -R to the publish job's gh release calls - #118

Closed
BeauBoorman wants to merge 1 commit into
drawmeanelephant:mainfrom
BeauBoorman:ci/fix-binaries-release
Closed

BeauBoorman wants to merge 1 commit into
drawmeanelephant:mainfrom
BeauBoorman:ci/fix-binaries-release

Conversation

@BeauBoorman

@BeauBoorman BeauBoorman commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Closes #117

What

The Binaries workflow's publish job has failed on every run since the #100 restructure (10/10, first failure = the #100 merge run itself; last success = #99's, the pre-split layout). Build and smoke-windows pass; publish dies before any API call. This passes -R "$GITHUB_REPOSITORY" to the three gh release calls so they address the repository directly.

Changes

  • .github/workflows/binaries.yml — publish job's gh release view / create / upload each gain -R "$GITHUB_REPOSITORY", plus a comment recording why: the job deliberately has no checkout (it only ships artifacts), and without -R gh falls back to git discovery and dies with failed to run git: fatal: not a git repository — the exact error in every failed-run log since Aug 17. No checkout step added; no other jobs touched. The top-level permissions: contents: write was already correct and is unchanged.

Tests

No unit tests (workflow-only change; no parser/model/renderer/library files touched). The validation is actionlint plus the local suite proving nothing else moved, and the next push to main repopulating the builds release is the end-to-end proof.

Verification

  • actionlint .github/workflows/*.yml → clean (exit 0)
  • zig build test --summary all → all six suites pass: 317 + 18 + 7 + 91 + 19 + 1 = 453/453 (same totals as fix: recognize oliver wrap subcommand in parseArgs (#115) #116)
  • root-cause repro outside a git tree:
    $ cd /tmp && gh release view builds
    failed to run git: fatal: not a git repository (or any of the parent directories): .git   # exit 1
    $ cd /tmp && gh release view builds -R drawmeanelephant/oliver
    title: Oliver prebuilt binaries   # exit 0
    
  • diff review: 3 command lines changed, 4 comment lines added, nothing else (git show dbdd4c3 --stat → 1 file, +7/−3)

No CHANGELOG in this repo, so no bullet.

Note: this PR shows zero checks — the fork’s first workflow run sits in GitHub’s action_required state awaiting maintainer approval, not failing; the actionlint + 453/453 verification above ran locally on the pushed commit dbdd4c3.

…ant#117)

Every Binaries run since the drawmeanelephant#100 restructure fails at the Publish step:
the publish job has no checkout (it only ships artifacts), and gh falls
back to git repository discovery when no -R is given — with no .git in
the job workspace it dies with "failed to run git: fatal: not a git
repository" before ever reaching the API. The top-level
permissions: contents: write was never the problem.

Pass -R "$GITHUB_REPOSITORY" to release view/create/upload so the calls
address the repo directly; no checkout step, no other behavior changes.
@drawmeanelephant

Copy link
Copy Markdown
Owner

Thanks @BeauBoorman — landed as #119 (same diff dbdd4c3) via same-repo branch to satisfy the required checks without fork approval. Closing this as superseded; the fix is now on at 4f612a4. Closes #117.

@drawmeanelephant

Copy link
Copy Markdown
Owner

Superseded by #119 (same commit landed on main as 4f612a4).

auto-merge was automatically disabled August 24, 2026 23:27

Pull request was closed

@BeauBoorman
BeauBoorman deleted the ci/fix-binaries-release branch August 25, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: binaries publish job fails on every run — gh release calls lack repo context

2 participants