fix(ci): pass -R to the publish job's gh release calls - #118
Closed
BeauBoorman wants to merge 1 commit into
Closed
BeauBoorman wants to merge 1 commit into
BeauBoorman wants to merge 1 commit into
Conversation
…ant#117) Every Binaries run since the drawmeanelephant#100 restructure fails at the Publish step: the publish job has no checkout (it only ships artifacts), and gh falls back to git repository discovery when no -R is given — with no .git in the job workspace it dies with "failed to run git: fatal: not a git repository" before ever reaching the API. The top-level permissions: contents: write was never the problem. Pass -R "$GITHUB_REPOSITORY" to release view/create/upload so the calls address the repo directly; no checkout step, no other behavior changes.
Owner
|
Thanks @BeauBoorman — landed as #119 (same diff dbdd4c3) via same-repo branch to satisfy the required checks without fork approval. Closing this as superseded; the fix is now on at 4f612a4. Closes #117. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
What
The Binaries workflow's publish job has failed on every run since the #100 restructure (10/10, first failure = the #100 merge run itself; last success = #99's, the pre-split layout). Build and smoke-windows pass; publish dies before any API call. This passes
-R "$GITHUB_REPOSITORY"to the threegh releasecalls so they address the repository directly.Changes
.github/workflows/binaries.yml— publish job'sgh release view/create/uploadeach gain-R "$GITHUB_REPOSITORY", plus a comment recording why: the job deliberately has no checkout (it only ships artifacts), and without-Rgh falls back to git discovery and dies withfailed to run git: fatal: not a git repository— the exact error in every failed-run log since Aug 17. No checkout step added; no other jobs touched. The top-levelpermissions: contents: writewas already correct and is unchanged.Tests
No unit tests (workflow-only change; no parser/model/renderer/library files touched). The validation is actionlint plus the local suite proving nothing else moved, and the next push to
mainrepopulating thebuildsrelease is the end-to-end proof.Verification
actionlint .github/workflows/*.yml→ clean (exit 0)zig build test --summary all→ all six suites pass: 317 + 18 + 7 + 91 + 19 + 1 = 453/453 (same totals as fix: recognize oliver wrap subcommand in parseArgs (#115) #116)git show dbdd4c3 --stat→ 1 file, +7/−3)No CHANGELOG in this repo, so no bullet.
Note: this PR shows zero checks — the fork’s first workflow run sits in GitHub’s
action_requiredstate awaiting maintainer approval, not failing; theactionlint+ 453/453 verification above ran locally on the pushed commitdbdd4c3.