Skip to content

fix(ci): pass -R to the publish job's gh release calls - #119

Merged
drawmeanelephant merged 1 commit into
mainfrom
ci/fix-binaries-release-local
Aug 24, 2026
Merged

drawmeanelephant merged 1 commit into
mainfrom
ci/fix-binaries-release-local

Conversation

@drawmeanelephant

Copy link
Copy Markdown
Owner

Closes #117

Same as #118 (BeauBoorman/oliver@dbdd4c3) but from a same-repo branch so CI runs without approval.

See #118 description for root-cause repro + verification.

Co-authored from BeauBoorman/oliver:ci/fix-binaries-release

Every Binaries run since the #100 restructure fails at the Publish step:
the publish job has no checkout (it only ships artifacts), and gh falls
back to git repository discovery when no -R is given — with no .git in
the job workspace it dies with "failed to run git: fatal: not a git
repository" before ever reaching the API. The top-level
permissions: contents: write was never the problem.

Pass -R "$GITHUB_REPOSITORY" to release view/create/upload so the calls
address the repo directly; no checkout step, no other behavior changes.

Closes #117
Co-authored-from: BeauBoorman/oliver@dbdd4c3
@drawmeanelephant
drawmeanelephant merged commit 4f612a4 into main Aug 24, 2026
3 checks passed
@drawmeanelephant
drawmeanelephant deleted the ci/fix-binaries-release-local branch August 24, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: binaries publish job fails on every run — gh release calls lack repo context

1 participant