fix(meta): keep quoted scalars containing ": " in oliver meta output (#120) - #121
Merged
Merged
Conversation
…120) The per-field extraction checked the bare-scalar out-of-subset rejects (embedded ": ", inline comments, leading indicators) before attempting quote decoding, so any quoted scalar containing ": " was projected as "" — e.g. title: "Has: Colon" rendered an empty $title$ downstream. Classification now happens inside decodeScalar after the quoted forms, mirroring frontmatter.parseScalar's order (quoted scalars are opaque; only bare scalars reject ": "). Bare out-of-subset values still project "". Adds regression tests for every row of the issue characterization table and pins the library parse path in frontmatter.zig.
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oliver metasilently projected""for any frontmatter key whose value was a quoted scalar containing:, because the per-field extraction ran the bare-scalar out-of-subset rejects (embedded:, inline comments, leading indicators) before quote decoding. The value never reacheddecodeScalar, which handles quoted forms correctly — sotitle: "Has: Colon"produced an empty field and downstream templates rendered an emptyFix
Classification now happens inside
decodeScalarafter the quoted forms, mirroringfrontmatter.parseScalar's existing order (src/frontmatter.zig:422): a quoted scalar is opaque data, and only bare scalars reject an embedded:/#/ leading indicator. Bare out-of-subset values still project"".Characterization (from the issue)
title: "Has: Colon"Has: Colondescription: "Desc: here"+author: "A: B"title: 'Single: Colon'Single: Colontitle: "NoSpace:Colon"title: "Trailing: "Trailing:verbatimtitle: Unquoted: Colon ValueTests
meta: quoted scalars may contain ": " (issue #120)covering every row above.frontmatter.zigfor the library parse path (--frontmatter yamlwas already correct).zig build test --summary all).