Repository navigation
chore: sync public mirror from internal - #1371
Conversation
|
Resolved 0 review-bot thread(s) on this generated public mirror PR. Review of mirrored code belongs on the mono source PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4915be67cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # The startup client can time out just before its job-local daemon becomes | ||
| # ready. The existing statistics request must still succeed and prove the | ||
| # selected backend; a timeout alone never admits an unavailable cache. | ||
| echo "::warning::sccache startup client timed out; checking daemon readiness" |
There was a problem hiding this comment.
Require a daemon connection before accepting the timeout
When --start-server times out because backend initialization never completes, this branch continues on the assumption that --show-stats proves daemon readiness. However, the sccache v0.17.0 used by setup-rust explicitly synthesizes mostly empty statistics when it cannot connect to a server and exits successfully; it also derives the reported cache location from the configuration, so the checks below can pass with no daemon running (sccache v0.17.0 source). The setup action then succeeds, but subsequent compiler invocations can repeatedly attempt and fail to start the missing daemon. Use a probe that fails unless it connects to the job's UDS, or retry until that socket accepts a connection before suppressing the startup error.
Useful? React with 👍 / 👎.
Summary
dx-corp/monodx-corp/codeas a generated public mirror of the private source of truth871bfe3ec25bd3506fe2725b8a893bb372a30928ab0c9ce0cfe05d6ac5519333466b87b03fa11a0c2file(s) to copy/update and0stale file(s) to delete0sync-holdlabel to this PR; the sync workflow skips every push while it is setSource-of-truth status
Projection: deixic-code
Source: dx-corp/mono@871bfe3ec25bd3506fe2725b8a893bb372a30928
Prior destination base: ab0c9ce
Content SHA-256: 880c2ccbeadddda04e3edcfcd39e25a881ef94e89baca25c58c3d4af9b9a66bb
Result: drift_detected; 2 changed, 0 deleted
Destination-owned content is preserved. Destination CI is a separate health signal.
copy/update .github/actions/setup-sccache/configure.sh
copy/update .repository-projection.json
Drift sample
Public-only commits since last generated sync
Validation
Test Plan
maestro-sync-public-release-mirrorworkflow inpublic-treemoderequire-internal-prconfirms internal source PR lineageStaged Rollout
dx-corp/mono@871bfe3ec25bd3506fe2725b8a893bb372a30928, including existing hidden/evaluation surfaces, and keeps public package parity behind the established public-source-provenance gate.