Repository navigation
chore: sync public mirror from internal #1371
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -312,7 +312,19 @@ | |
| unset SCCACHE_GCS_BUCKET SCCACHE_GCS_RW_MODE SCCACHE_GCS_KEY_PREFIX | ||
| fi | ||
|
|
||
| if startup_output="$("${SCCACHE_BIN}" --start-server 2>&1)"; then | ||
| printf '%s\n' "${startup_output}" | ||
| else | ||
| startup_status=$? | ||
| printf '%s\n' "${startup_output}" >&2 | ||
| if [[ "${startup_output}" != *"Timed out waiting for server startup"* ]]; then | ||
| exit "${startup_status}" | ||
| fi | ||
| # The startup client can time out just before its job-local daemon becomes | ||
| # ready. The existing statistics request must still succeed and prove the | ||
| # selected backend; a timeout alone never admits an unavailable cache. | ||
| echo "::warning::sccache startup client timed out; checking daemon readiness" | ||
|
Check failure on line 326 in .github/actions/setup-sccache/configure.sh
|
||
| fi | ||
| stats="$("${SCCACHE_BIN}" --show-stats)" | ||
| printf '%s\n' "${stats}" | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
--start-servertimes out because backend initialization never completes, this branch continues on the assumption that--show-statsproves daemon readiness. However, the sccache v0.17.0 used bysetup-rustexplicitly synthesizes mostly empty statistics when it cannot connect to a server and exits successfully; it also derives the reported cache location from the configuration, so the checks below can pass with no daemon running (sccache v0.17.0 source). The setup action then succeeds, but subsequent compiler invocations can repeatedly attempt and fail to start the missing daemon. Use a probe that fails unless it connects to the job's UDS, or retry until that socket accepts a connection before suppressing the startup error.Useful? React with 👍 / 👎.